From: Arnd Bergmann <arnd@arndb.de>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Vinod Koul <vinod.koul@intel.com>,
Lars-Peter Clausen <lars@metafoo.de>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, Andy Gross <agross@codeaurora.org>,
dmaengine@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [Patch v3 2/2] dmaengine: qcom_bam_dma: Add device tree binding
Date: Wed, 29 Jan 2014 16:05:22 +0100 [thread overview]
Message-ID: <21038487.ygragjUUsd@wuerfel> (raw)
In-Reply-To: <20140128121656.GH15937@n2100.arm.linux.org.uk>
On Tuesday 28 January 2014 12:16:56 Russell King - ARM Linux wrote:
> On Tue, Jan 28, 2014 at 01:08:47PM +0100, Arnd Bergmann wrote:
>
> On balance, I think the virtual channel approach makes client drivers
> more elegant and simpler, and makes the DMA engine API easier to use,
> and gives greater flexibility for future improvements. So, I wouldn't
> miss the slave_id being removed.
Ok, good. There are some dmaengine drivers that actually behave
in hardware like the virtual-channel extension, i.e. they have
one physical channel per request line (qcom_bam_dma seems to be
one of them in fact), so they don't really have a choice.
The way that both the DT and ACPI bindings are structured,
the request ID is always known by the time the channel is
allocated to allow this model, and that means supporting both
approaches in the same master or slave driver is a mess.
Arnd
next prev parent reply other threads:[~2014-01-29 15:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-28 6:27 [Patch v3 0/2] Add Qualcomm BAM dmaengine driver Andy Gross
2014-01-28 6:27 ` [Patch v3 1/2] dmaengine: add Qualcomm BAM dma driver Andy Gross
2014-01-28 6:27 ` [Patch v3 2/2] dmaengine: qcom_bam_dma: Add device tree binding Andy Gross
2014-01-28 9:05 ` Lars-Peter Clausen
2014-01-28 9:16 ` Arnd Bergmann
2014-01-28 11:17 ` Russell King - ARM Linux
2014-01-28 11:32 ` Vinod Koul
2014-01-28 12:05 ` Arnd Bergmann
2014-01-28 12:08 ` Arnd Bergmann
2014-01-28 12:16 ` Russell King - ARM Linux
2014-01-29 15:05 ` Arnd Bergmann [this message]
2014-01-28 13:01 ` Russell King - ARM Linux
2014-01-28 19:50 ` Andy Gross
2014-01-30 6:23 ` Andy Gross
2014-01-28 19:47 ` Andy Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21038487.ygragjUUsd@wuerfel \
--to=arnd@arndb.de \
--cc=agross@codeaurora.org \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox