From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC5DDC433DF for ; Wed, 26 Aug 2020 14:40:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C4B602080C for ; Wed, 26 Aug 2020 14:40:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727022AbgHZOke (ORCPT ); Wed, 26 Aug 2020 10:40:34 -0400 Received: from mga11.intel.com ([192.55.52.93]:3727 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726905AbgHZOkZ (ORCPT ); Wed, 26 Aug 2020 10:40:25 -0400 IronPort-SDR: RfPfYohHD/s0/CXUENx3YY6C9Wt28AebuilvA8xR42ZRqxFtDoi23FoYBzhSxqFepRsgg2/rP9 HukA5ooFl3hg== X-IronPort-AV: E=McAfee;i="6000,8403,9725"; a="153869877" X-IronPort-AV: E=Sophos;i="5.76,356,1592895600"; d="scan'208";a="153869877" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Aug 2020 07:40:24 -0700 IronPort-SDR: KHxkWteeU8emhyHgGfiOwbt/dsY21nC8/UY5bgPeCNc+exWvdcy9vNMmiijVfwhXIoSVnfVsLW iZeVF4gNESwA== X-IronPort-AV: E=Sophos;i="5.76,356,1592895600"; d="scan'208";a="299494879" Received: from gillelas-mobl1.amr.corp.intel.com (HELO [10.255.231.51]) ([10.255.231.51]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Aug 2020 07:40:23 -0700 Subject: Re: [PATCH 09/11] soundwire: intel: add dynamic debug trace for clock-stop invalid configs To: Vinod Koul , Bard Liao Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, tiwai@suse.de, broonie@kernel.org, gregkh@linuxfoundation.org, jank@cadence.com, srinivas.kandagatla@linaro.org, rander.wang@linux.intel.com, ranjani.sridharan@linux.intel.com, hui.wang@canonical.com, sanyog.r.kale@intel.com, mengdong.lin@intel.com, bard.liao@intel.com References: <20200818024120.20721-1-yung-chuan.liao@linux.intel.com> <20200818024120.20721-10-yung-chuan.liao@linux.intel.com> <20200826094817.GC2639@vkoul-mobl> From: Pierre-Louis Bossart Message-ID: <21038e8d-dbd9-76c7-c758-9933fb45024a@linux.intel.com> Date: Wed, 26 Aug 2020 09:38:38 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200826094817.GC2639@vkoul-mobl> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/26/20 4:48 AM, Vinod Koul wrote: > On 18-08-20, 10:41, Bard Liao wrote: >> From: Pierre-Louis Bossart >> >> Detect cases where the clock is assumed to be stopped but the IP is >> not in the relevant state, and add a dynamic debug trace. > > you meant a debug print..and it looks like error print below (also in title). I don't understand the comment. Is the 'trace' confusing and are you asking to e.g. change the commit message to 'add dynamic debug log'? > >> >> Signed-off-by: Pierre-Louis Bossart >> Signed-off-by: Bard Liao >> --- >> drivers/soundwire/intel.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c >> index 7c63581270fd..b82d02af3c4f 100644 >> --- a/drivers/soundwire/intel.c >> +++ b/drivers/soundwire/intel.c >> @@ -1964,6 +1964,11 @@ static int intel_resume_runtime(struct device *dev) >> } >> } >> } else if (!clock_stop_quirks) { >> + >> + clock_stop0 = sdw_cdns_is_clock_stop(&sdw->cdns); >> + if (!clock_stop0) >> + dev_err(dev, "%s invalid configuration, clock was not stopped", __func__); >> + >> ret = intel_init(sdw); >> if (ret) { >> dev_err(dev, "%s failed: %d", __func__, ret); >> -- >> 2.17.1 >