From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761455AbdACViN (ORCPT ); Tue, 3 Jan 2017 16:38:13 -0500 Received: from mout.kundenserver.de ([212.227.17.10]:60159 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756575AbdACViA (ORCPT ); Tue, 3 Jan 2017 16:38:00 -0500 From: Arnd Bergmann To: Nicolas Dichtel Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, netdev@vger.kernel.org, linux-media@vger.kernel.org, linux-mmc@vger.kernel.org, netfilter-devel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-raid@vger.kernel.org, linux-spi@vger.kernel.org, linux-mtd@lists.infradead.org, linux-rdma@vger.kernel.org, fcoe-devel@open-fcoe.org, alsa-devel@alsa-project.org, linux-fbdev@vger.kernel.org, xen-devel@lists.xenproject.org, davem@davemloft.net, airlied@linux.ie, David Howells Subject: Re: [PATCH] uapi: use wildcards to list files Date: Tue, 03 Jan 2017 22:37:04 +0100 Message-ID: <2108827.WpE3IvfEdH@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1483454144-10519-1-git-send-email-nicolas.dichtel@6wind.com> References: <20161203.192346.1198940437155108508.davem@davemloft.net> <1483454144-10519-1-git-send-email-nicolas.dichtel@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:Tp4gh3IsAE60BM8BRJhjJCJB9Z9xEArhw4+sqU92wb7Ovo4JFoV rma6aElwDNB9PsgAKnVRygTqSsjI0ZTP4xalzeT89iQcqEo+rI3GV1SUJTeJUeIYaMEOYes 7IYQ1EGDGw5o5zKl5duLVWmqi9QGc/9blBvygF2WplOhSunbEGqqbrt3+FrqtgzhPS0N4NK LU3gplYgh87fRZ6q4XpUQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:AodZldpcE5U=:INj3dBQ8vJiohoAlA/ZuLn dc3XCE6MbN+5nNriKQhKUcEA1Po8F1qXs/XhBfT9Ann0Gb5JQDDWl+e6jZpeDVJlXYbQgy3jC 6C/bfW659jVVg79HkYxGXVIUp1buzTrqlvpe5/IbmbuXNiyhLQmkbcR6cmoc2zOyLg2Jijk4d XO7R25hweZQDNySiQbbJcxIweI1i1niFKlUmnmzpT/Ph3B33eyv8xTvXw6ZynahWQ3ueT3jwC lnCfNFLH4rnhu71UP1RXEouJgarEIn8hP/HLVMp56lgoRe6+j74amEaqvZkFWozzUnYPbDQ7A b3HEoxSCiHq6vKo8aUxafZYNoq3kg2CzaPz4FdjZeiNfe/aZ0EnUG1IGQGNSgiNrUiCVlwWL1 H5wkttDMZbVz5OVo2bQxTtoFbQARtRHLKK5FPfHGKpFyLe8P8K91nujMZeqZrVf87lOXwe6o8 0HUH4uBfgnQ12KLZwYJNKTBKXljG9XXZw7WyoytzHmiXCXo9HdmVNj0NCBsKwSqUt7qHYa3Rd nTyUjdQkX+06c9Ysta7iv2GM/HJIY3EBLe1sy2YCQODzQpHqkQTdKoLfCrEF4tYiKEIFWjcZI Unmg/OQmABpfVPv0wKFUtZJik5FVpUYOPGU/7huDTnvd/1BEOiST9ibGAV5oA1owxe9/Ltmme wQ272ycSSqosXUyxBb0dcnYCMvwiiZM3f1jBIM8fkX2BUWADr5c4jsfBDhnUNJ1/pY1bJQaTi K9vjQel1Yu0CMjHW Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, January 3, 2017 3:35:44 PM CET Nicolas Dichtel wrote: > Regularly, when a new header is created in include/uapi/, the developer > forgets to add it in the corresponding Kbuild file. This error is usually > detected after the release is out. > > In fact, all headers under include/uapi/ should be exported, so let's > use wildcards. I think the idea makes a lot of sense: if a header is in uapi, we should really export it. However, using a wildcard expression seems a bit backwards here, I think we should make this implicit and not have the Kbuild file at all. The "header-y" syntax was originally added back when the uapi headers were mixed with the internal headers in the same directory. After David Howells introduced the separate directory for uapi, it has become a bit redundant. Can you try to modify scripts/Makefile.headersinst instead so we can simply remove the Kbuild files entirely? Arnd