From: Stephen Boyd <sboyd@kernel.org>
To: "Jonathan Hunter" <jonathanh@nvidia.com>,
"Michael Turquette" <mturquette@baylibre.com>,
"Peter De Schrijver" <pdeschrijver@nvidia.com>,
"Prashant Gaikwad" <pgaikwad@nvidia.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 26/30] clk: tegra: Convert to platform remove callback returning void
Date: Tue, 28 Mar 2023 19:40:22 -0700 [thread overview]
Message-ID: <21136043a4c745abca60afb206b980f6.sboyd@kernel.org> (raw)
In-Reply-To: <20230312161512.2715500-27-u.kleine-koenig@pengutronix.de>
Quoting Uwe Kleine-König (2023-03-12 09:15:08)
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
Applied to clk-next
next prev parent reply other threads:[~2023-03-29 2:41 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-12 16:14 [PATCH 00/30] clk: Convert to platform remove callback returning void Uwe Kleine-König
2023-03-12 16:14 ` [PATCH 01/30] clk: mediatek: Make mtk_clk_simple_remove() return void Uwe Kleine-König
2023-03-13 8:54 ` AngeloGioacchino Del Regno
2023-03-13 9:45 ` Uwe Kleine-König
2023-03-12 16:14 ` [PATCH 02/30] clk: tegra: Don't warn three times about failure to unregister Uwe Kleine-König
2023-03-29 2:34 ` Stephen Boyd
2023-03-12 16:14 ` [PATCH 03/30] clk: xilinx: Drop if block with always false condition Uwe Kleine-König
2023-03-29 2:35 ` Stephen Boyd
2023-03-12 16:14 ` [PATCH 04/30] clk: axs10x: Convert to platform remove callback returning void Uwe Kleine-König
2023-03-29 2:35 ` Stephen Boyd
2023-03-12 16:14 ` [PATCH 05/30] clk: bcm: " Uwe Kleine-König
2023-03-14 21:28 ` Florian Fainelli
2023-03-29 2:35 ` Stephen Boyd
2023-03-12 16:14 ` [PATCH 06/30] clk: axi-clkgen: " Uwe Kleine-König
2023-03-29 2:36 ` Stephen Boyd
2023-03-12 16:14 ` [PATCH 07/30] clk: axm5516: " Uwe Kleine-König
2023-03-29 2:36 ` Stephen Boyd
2023-03-12 16:14 ` [PATCH 08/30] clk: fixed-factor: " Uwe Kleine-König
2023-03-29 2:36 ` Stephen Boyd
2023-03-12 16:14 ` [PATCH 09/30] clk: fixed-mmio: " Uwe Kleine-König
2023-03-29 2:36 ` Stephen Boyd
2023-03-12 16:14 ` [PATCH 10/30] clk: fixed-rate: " Uwe Kleine-König
2023-03-29 2:37 ` Stephen Boyd
2023-03-12 16:14 ` [PATCH 11/30] clk: hsdk-pll: " Uwe Kleine-König
2023-03-29 2:37 ` Stephen Boyd
2023-03-12 16:14 ` [PATCH 12/30] clk: palmas: " Uwe Kleine-König
2023-03-29 2:37 ` Stephen Boyd
2023-03-12 16:14 ` [PATCH 13/30] clk: pwm: " Uwe Kleine-König
2023-03-29 2:37 ` Stephen Boyd
2023-03-12 16:14 ` [PATCH 14/30] clk: s2mps11: " Uwe Kleine-König
2023-03-12 16:22 ` Krzysztof Kozlowski
2023-03-29 2:37 ` Stephen Boyd
2023-03-12 16:14 ` [PATCH 15/30] clk: scpi: " Uwe Kleine-König
2023-03-16 15:01 ` Sudeep Holla
2023-03-16 15:48 ` Uwe Kleine-König
2023-03-17 0:31 ` Stephen Boyd
2023-03-29 2:38 ` Stephen Boyd
2023-03-12 16:14 ` [PATCH 16/30] clk: stm32mp1: " Uwe Kleine-König
2023-03-29 2:38 ` Stephen Boyd
2023-03-12 16:14 ` [PATCH 17/30] clk: hisilicon: " Uwe Kleine-König
2023-03-29 2:38 ` Stephen Boyd
2023-03-12 16:15 ` [PATCH 18/30] clk: keystone: " Uwe Kleine-König
2023-03-29 2:39 ` Stephen Boyd
2023-03-12 16:15 ` [PATCH 19/30] clk: mediatek: " Uwe Kleine-König
2023-03-29 2:39 ` Stephen Boyd
2023-03-12 16:15 ` [PATCH 20/30] clk: mmp: " Uwe Kleine-König
2023-03-29 2:39 ` Stephen Boyd
2023-03-12 16:15 ` [PATCH 21/30] clk: mvebu: " Uwe Kleine-König
2023-03-29 2:39 ` Stephen Boyd
2023-03-12 16:15 ` [PATCH 22/30] clk: qcom: " Uwe Kleine-König
2023-03-12 16:15 ` [PATCH 23/30] clk: renesas: " Uwe Kleine-König
2023-03-13 9:05 ` Geert Uytterhoeven
2023-03-12 16:15 ` [PATCH 24/30] clk: samsung: " Uwe Kleine-König
2023-03-12 16:33 ` (subset) " Krzysztof Kozlowski
2023-03-12 16:15 ` [PATCH 25/30] clk: stm32: " Uwe Kleine-König
2023-03-29 2:40 ` Stephen Boyd
2023-03-12 16:15 ` [PATCH 26/30] clk: tegra: " Uwe Kleine-König
2023-03-29 2:40 ` Stephen Boyd [this message]
2023-03-12 16:15 ` [PATCH 27/30] clk: ti: " Uwe Kleine-König
2023-03-29 2:40 ` Stephen Boyd
2023-03-12 16:15 ` [PATCH 28/30] clk: uniphier: " Uwe Kleine-König
2023-03-29 2:40 ` Stephen Boyd
2023-03-12 16:15 ` [PATCH 29/30] clk: x86: " Uwe Kleine-König
2023-03-29 2:40 ` Stephen Boyd
2023-03-12 16:15 ` [PATCH 30/30] clk: xilinx: " Uwe Kleine-König
2023-03-29 2:41 ` Stephen Boyd
2023-03-15 23:35 ` (subset) [PATCH 00/30] clk: " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21136043a4c745abca60afb206b980f6.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=pdeschrijver@nvidia.com \
--cc=pgaikwad@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox