From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68E6AC761AF for ; Wed, 29 Mar 2023 02:41:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229572AbjC2ClB (ORCPT ); Tue, 28 Mar 2023 22:41:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229734AbjC2Ck6 (ORCPT ); Tue, 28 Mar 2023 22:40:58 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A06E35A8; Tue, 28 Mar 2023 19:40:35 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9D1D8B81F88; Wed, 29 Mar 2023 02:40:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3238FC433D2; Wed, 29 Mar 2023 02:40:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680057624; bh=CaMQ35XV8yS1qRP6pCVhCK5Q0eSKnfCwitxVdmBVpaM=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=n3jjCU1CzUs8+R2hX05V74EN/qbvqSzdk1x/8/YLL09CI2m8zvjirDoIVaqxFbP4g wPeiRI6jebabWbS2C7Fe+u9wkqK4/qLXU0N5p7kG3RJ4/woB0CKc1tSzjMIWo/jdmp vxdgWurQPO5abPEKHqKilrBmLbnSyvIZQ0cu2ZYxFO1a+h8CZtQmQK4j+X/RLgxsVF NeLEDdTPB2fAJ78/0yAQwMefu5ZLgnlg15h/KfRTT1rReC9OMCDPPkezRe8NLdD+sJ iXvRaQ+nIOSTkIsGNfZg6H42GSPHr/OW6fCydd+d0xKDuvFcTa1Ug94sN2zDXQzNWe A4EeBLIbWqVkQ== Message-ID: <21136043a4c745abca60afb206b980f6.sboyd@kernel.org> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20230312161512.2715500-27-u.kleine-koenig@pengutronix.de> References: <20230312161512.2715500-1-u.kleine-koenig@pengutronix.de> <20230312161512.2715500-27-u.kleine-koenig@pengutronix.de> Subject: Re: [PATCH 26/30] clk: tegra: Convert to platform remove callback returning void From: Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org To: Jonathan Hunter , Michael Turquette , Peter De Schrijver , Prashant Gaikwad , Thierry Reding , Uwe =?utf-8?q?Kleine-K=C3=B6nig?= Date: Tue, 28 Mar 2023 19:40:22 -0700 User-Agent: alot/0.10 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Uwe Kleine-K=C3=B6nig (2023-03-12 09:15:08) > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. >=20 > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. >=20 > Signed-off-by: Uwe Kleine-K=C3=B6nig > --- Applied to clk-next