From: "Jérôme Pouiller" <jerome.pouiller@silabs.com>
To: gregkh@linuxfoundation.org, Suraj Upadhyay <usuraj35@gmail.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 5/6] staging: wfx/hif_rx.c: Fix spelling mistake "negociation" => "negotiation"
Date: Thu, 20 Aug 2020 11:11:16 +0200 [thread overview]
Message-ID: <2117465.u6biEVJElo@pc-42> (raw)
In-Reply-To: <eab6bcb570dcd1407efc8163ff8ff976f623ae9c.1597913333.git.usuraj35@gmail.com>
Hello Suraj,
Thank you for your contribution.
On Thursday 20 August 2020 10:51:27 CEST Suraj Upadhyay wrote:
>
> Signed-off-by: Suraj Upadhyay <usuraj35@gmail.com>
Even for a small change, you have to fill the commit log body.
> ---
> drivers/staging/wfx/hif_rx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wfx/hif_rx.c b/drivers/staging/wfx/hif_rx.c
> index cc7c0cf226ba..1d32973d8ec1 100644
> --- a/drivers/staging/wfx/hif_rx.c
> +++ b/drivers/staging/wfx/hif_rx.c
> @@ -118,7 +118,7 @@ static int hif_keys_indication(struct wfx_dev *wdev,
>
> // SL_PUB_KEY_EXCHANGE_STATUS_SUCCESS is used by legacy secure link
> if (body->status && body->status != HIF_STATUS_SLK_NEGO_SUCCESS)
> - dev_warn(wdev->dev, "secure link negociation error\n");
> + dev_warn(wdev->dev, "secure link negotiation error\n");
This change is already in the staging tree. See commit c9638363f02d
("staging: wfx: fix a handful of spelling mistakes").
Globally, if you post changes for drivers/staging you should rebase your
work on the staging tree before to send it. You can use the script
get_maintainer.pl to get this information:
$ ./scripts/get_maintainer.pl --scm drivers/staging/wfx
[...]
git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
--
Jérôme Pouiller
next prev parent reply other threads:[~2020-08-20 9:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-20 8:49 [PATCH 1/6] staging: wfx/main.h: fix a spelling and grammar mistake Suraj Upadhyay
2020-08-20 8:50 ` [PATCH 2/6] staging: wfx/main.c: Fix a spelling mistake "negociate" => "negotiate" Suraj Upadhyay
2020-08-20 8:50 ` [PATCH 3/6] staging: wfx/data_rx.c: Fix spelling mistake "negociation" => "negotiation" Suraj Upadhyay
2020-08-20 8:50 ` [PATCH 4/6] staging: wfx/debug.c: Fix spelling mistake "carefull" => "careful" Suraj Upadhyay
2020-08-20 9:13 ` Jérôme Pouiller
2020-08-20 8:51 ` [PATCH 5/6] staging: wfx/hif_rx.c: Fix spelling mistake "negociation" => "negotiation" Suraj Upadhyay
2020-08-20 9:11 ` Jérôme Pouiller [this message]
2020-08-20 8:51 ` [PATCH 6/6] staging: wfx/hif_tx.c: Fix spelling mistake "carefull" => "careful" Suraj Upadhyay
2020-08-20 9:17 ` [PATCH 1/6] staging: wfx/main.h: fix a spelling and grammar mistake Jérôme Pouiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2117465.u6biEVJElo@pc-42 \
--to=jerome.pouiller@silabs.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=usuraj35@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox