From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49113C5DF60 for ; Fri, 8 Nov 2019 09:36:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2460F214DA for ; Fri, 8 Nov 2019 09:36:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731273AbfKHJgL (ORCPT ); Fri, 8 Nov 2019 04:36:11 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:24896 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731028AbfKHJgF (ORCPT ); Fri, 8 Nov 2019 04:36:05 -0500 Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id xA89WFZ0091251 for ; Fri, 8 Nov 2019 04:36:04 -0500 Received: from e06smtp03.uk.ibm.com (e06smtp03.uk.ibm.com [195.75.94.99]) by mx0b-001b2d01.pphosted.com with ESMTP id 2w541c3vv1-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 08 Nov 2019 04:36:03 -0500 Received: from localhost by e06smtp03.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 8 Nov 2019 09:36:01 -0000 Received: from b06avi18626390.portsmouth.uk.ibm.com (9.149.26.192) by e06smtp03.uk.ibm.com (192.168.101.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Fri, 8 Nov 2019 09:35:57 -0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06avi18626390.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id xA89ZLIj41877838 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 8 Nov 2019 09:35:21 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6EB0811C04C; Fri, 8 Nov 2019 09:35:56 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 19A4511C050; Fri, 8 Nov 2019 09:35:56 +0000 (GMT) Received: from ozlabs.au.ibm.com (unknown [9.192.253.14]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Fri, 8 Nov 2019 09:35:56 +0000 (GMT) Received: from townsend.localnet (unknown [9.81.221.11]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.au.ibm.com (Postfix) with ESMTPSA id 74862A027A; Fri, 8 Nov 2019 20:35:53 +1100 (AEDT) From: Alistair Popple To: Joel Stanley Cc: Rob Herring , Greg KH , Jeremy Kerr , Andrew Jeffery , Eddie James , Steven Rostedt , Ingo Molnar , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-fsi@lists.ozlabs.org Subject: Re: [PATCH v2 04/11] trace: fsi: Print transfer size unsigned Date: Fri, 08 Nov 2019 20:21:01 +1100 In-Reply-To: <20191108051945.7109-5-joel@jms.id.au> References: <20191108051945.7109-1-joel@jms.id.au> <20191108051945.7109-5-joel@jms.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-TM-AS-GCONF: 00 x-cbid: 19110809-0012-0000-0000-00000361D4FD X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19110809-0013-0000-0000-0000219D38D5 Message-Id: <2120832.yXaHOgoxCj@townsend> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-11-08_02:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1034 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=811 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1910280000 definitions=main-1911080093 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Acked-by: Alistair Popple On Friday, 8 November 2019 4:19:38 PM AEDT Joel Stanley wrote: > From: Andrew Jeffery > > Due to other bugs I observed a spurious -1 transfer size. > > Signed-off-by: Andrew Jeffery > Signed-off-by: Joel Stanley > --- > include/trace/events/fsi.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/trace/events/fsi.h b/include/trace/events/fsi.h > index 92e5e89e52ed..9832cb8e0eb0 100644 > --- a/include/trace/events/fsi.h > +++ b/include/trace/events/fsi.h > @@ -26,7 +26,7 @@ TRACE_EVENT(fsi_master_read, > __entry->addr = addr; > __entry->size = size; > ), > - TP_printk("fsi%d:%02d:%02d %08x[%zd]", > + TP_printk("fsi%d:%02d:%02d %08x[%zu]", > __entry->master_idx, > __entry->link, > __entry->id, > @@ -56,7 +56,7 @@ TRACE_EVENT(fsi_master_write, > __entry->data = 0; > memcpy(&__entry->data, data, size); > ), > - TP_printk("fsi%d:%02d:%02d %08x[%zd] <= {%*ph}", > + TP_printk("fsi%d:%02d:%02d %08x[%zu] <= {%*ph}", > __entry->master_idx, > __entry->link, > __entry->id, > @@ -93,7 +93,7 @@ TRACE_EVENT(fsi_master_rw_result, > if (__entry->write || !__entry->ret) > memcpy(&__entry->data, data, size); > ), > - TP_printk("fsi%d:%02d:%02d %08x[%zd] %s {%*ph} ret %d", > + TP_printk("fsi%d:%02d:%02d %08x[%zu] %s {%*ph} ret %d", > __entry->master_idx, > __entry->link, > __entry->id, >