From: David Howells <dhowells@redhat.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: dhowells@redhat.com, linux-nfs@vger.kernel.org,
linux-kernel@vger.kernel.org, mhiramat@kernel.org,
bigeasy@linutronix.de
Subject: Re: Oops in rpc_clnt_debugfs_register() from debugfs change
Date: Tue, 12 Feb 2019 14:57:34 +0000 [thread overview]
Message-ID: <21212.1549983454@warthog.procyon.org.uk> (raw)
In-Reply-To: <20190212144214.GA17111@kroah.com>
Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> - if (!xprt->debugfs) {
> + if (IS_ERR_OR_NULL(xprt->debugfs)) {
That works, though I don't much like the idea of there being an error there.
Looking in rpc_xprt_debugfs_register() there are two now-dodgy looking checks
on the result of debugfs calls.
David
next prev parent reply other threads:[~2019-02-12 14:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <19914.1549970944@warthog.procyon.org.uk>
2019-02-12 14:31 ` Oops in rpc_clnt_debugfs_register() from debugfs change David Howells
2019-02-12 14:37 ` Greg Kroah-Hartman
2019-02-12 14:42 ` Greg Kroah-Hartman
2019-02-12 14:57 ` David Howells [this message]
2019-02-12 15:04 ` Greg Kroah-Hartman
2019-02-12 15:13 ` Greg Kroah-Hartman
2019-02-12 15:03 ` Greg Kroah-Hartman
2019-02-12 15:26 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21212.1549983454@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=bigeasy@linutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=mhiramat@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox