From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935457AbbI2SX6 (ORCPT ); Tue, 29 Sep 2015 14:23:58 -0400 Received: from mail-qg0-f46.google.com ([209.85.192.46]:34783 "EHLO mail-qg0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935434AbbI2SXt (ORCPT ); Tue, 29 Sep 2015 14:23:49 -0400 From: Paul Moore To: Yaowei Bai Cc: eparis@redhat.com, linux-audit@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] kernel/audit: audit_dummy_context can be boolean Date: Tue, 29 Sep 2015 14:23:46 -0400 Message-ID: <21234947.6vaOiuKnSs@sifl> User-Agent: KMail/4.14.10 (Linux/4.1.5-gentoo; KDE/4.14.12; x86_64; ; ) In-Reply-To: <1443536141-5134-1-git-send-email-bywxiaobai@163.com> References: <1443536141-5134-1-git-send-email-bywxiaobai@163.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, September 29, 2015 10:15:39 PM Yaowei Bai wrote: > This patch makes audit_dummy_context return bool due to this > particular function only using either one or zero as its return > value. > > No functional change. > > Signed-off-by: Yaowei Bai > --- > include/linux/audit.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Applied. > diff --git a/include/linux/audit.h b/include/linux/audit.h > index b2abc99..69844b6 100644 > --- a/include/linux/audit.h > +++ b/include/linux/audit.h > @@ -143,7 +143,7 @@ extern void __audit_inode_child(const struct inode > *parent, extern void __audit_seccomp(unsigned long syscall, long signr, int > code); extern void __audit_ptrace(struct task_struct *t); > > -static inline int audit_dummy_context(void) > +static inline bool audit_dummy_context(void) > { > void *p = current->audit_context; > return !p || *(int *)p; > @@ -345,9 +345,9 @@ static inline void audit_syscall_entry(int major, > unsigned long a0, { } > static inline void audit_syscall_exit(void *pt_regs) > { } > -static inline int audit_dummy_context(void) > +static inline bool audit_dummy_context(void) > { > - return 1; > + return true; > } > static inline struct filename *audit_reusename(const __user char *name) > { -- paul moore www.paul-moore.com