From: Sven Eckelmann <sven@narfation.org>
To: ron minnich <rminnich@gmail.com>
Cc: linux-mtd@lists.infradead.org, John Audia <graysky@archlinux.us>,
Adrian Schmutzler <freifunk@adrianschmutzler.de>,
jstefek@datto.com, Richard Weinberger <richard@nod.at>,
Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>,
Marek Vasut <marek.vasut@gmail.com>,
Boris Brezillon <boris.brezillon@collabora.com>,
Ron Minnich <rminnich@google.com>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH] mtd: parser: cmdline: Support MTD names containing one or more colons
Date: Fri, 27 Nov 2020 18:35:18 +0100 [thread overview]
Message-ID: <2124367.HovnAMPojK@sven-edge> (raw)
In-Reply-To: <CAP6exY+hHrVvaMcF2tWUUJT=JS_J9NHx=92DzO=GAN==ACSh1Q@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1804 bytes --]
On Friday, 27 November 2020 18:16:54 CET ron minnich wrote:
> What none of the people involved in the original patch knew was that
> there would be other ':' in use. Sorry!
>
> But you are right, my idea is a complete non-starter, don't know what
> I was thinking.
I am still not sure because I still didn't get what you actually wanted to
change. I first thought that you wanted to change
mtdparts=spi0.0:256k(0:SBL1)
to
mtdparts=spi0.0!256k(0:SBL1)
which wouldn't work for me when ":" is not supported anymore. And it would
break a lot of already working installations.
But maybe I completely misread it. Maybe you wanted to introduce an
optional(!!!) stop marker like !
mtdparts=spi0.0!:256k(0:SBL1)
to inform the parser that it doesn't have to search for : before the !. While
this could work for me, I am not qualified enough to say which character is
not yet used and can be utilized.
But the note about [ and ] at least makes sense to me (if it is optional):
mtdparts=[spi0.0]:256k(0:SBL1)
But I am not sure if this will be a problem for people which already adopted
PCI IDs inside the mtdparts without [ and ].
> So it seems your patch, if it works, is the way to go?
At least this is a workaround [1] which can be pushed to all the stable
kernels which broke with the "Support MTD names containing one or more colons"
patch. And the one which OpenWrt adopted now to get the devices booting again.
It is only waiting for a Tested-by from you.
> I can't think
> of anything better that lets us preserve current behavior and support
> PCI device specifiers?
I am not that deep in this topic. So I am not sure what else could be done.
Kind regards,
Sven
[1] https://patchwork.ozlabs.org/project/linux-mtd/patch/20201124062506.185392-1-sven@narfation.org/
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-11-27 17:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 16:53 [PATCH] mtd: parser: cmdline: Support MTD names containing one or more colons Ronald G. Minnich
2020-11-22 0:14 ` Sven Eckelmann
2020-11-27 16:32 ` ron minnich
2020-11-27 17:05 ` Sven Eckelmann
2020-11-27 17:16 ` ron minnich
2020-11-27 17:35 ` Sven Eckelmann [this message]
2020-11-27 18:54 ` ron minnich
2020-12-07 7:52 ` Sven Eckelmann
2020-12-07 15:24 ` ron minnich
2020-12-09 21:34 ` Ron Minnich
-- strict thread matches above, loose matches on Subject: below --
2020-09-25 4:21 [PATCH] mtd: spi-nor: controllers: intel-spi: Add support for command line partitions Vignesh Raghavendra
2020-12-23 21:56 ` [PATCH] mtd: parser: cmdline: Support MTD names containing one or more colons Ian Goegebuer
2021-01-04 9:08 ` Miquel Raynal
2021-01-04 16:24 ` Ron Minnich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2124367.HovnAMPojK@sven-edge \
--to=sven@narfation.org \
--cc=boris.brezillon@collabora.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=dwmw2@infradead.org \
--cc=freifunk@adrianschmutzler.de \
--cc=graysky@archlinux.us \
--cc=jstefek@datto.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
--cc=rminnich@gmail.com \
--cc=rminnich@google.com \
--cc=sashal@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox