From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40BAFC433EF for ; Thu, 9 Jun 2022 14:57:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344248AbiFIO5Z convert rfc822-to-8bit (ORCPT ); Thu, 9 Jun 2022 10:57:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344135AbiFIO5L (ORCPT ); Thu, 9 Jun 2022 10:57:11 -0400 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7077C3A79E3; Thu, 9 Jun 2022 07:57:05 -0700 (PDT) Received: from ip5b412258.dynamic.kabel-deutschland.de ([91.65.34.88] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nzJad-0006x1-AP; Thu, 09 Jun 2022 16:56:51 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Maya Matuszczyk , Krzysztof Kozlowski Cc: Arnd Bergmann , Olof Johansson , arm@kernel.org, soc@kernel.org, Rob Herring , Krzysztof Kozlowski , devicetree , arm-mail-list , "open list:ARM/Rockchip SoC..." , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 32/48] arm64: dts: rockchip: align gpio-key node names with dtschema Date: Thu, 09 Jun 2022 16:56:50 +0200 Message-ID: <2126178.C4sosBPzcN@diego> In-Reply-To: References: <20220609113721.379932-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Donnerstag, 9. Juni 2022, 16:15:25 CEST schrieb Krzysztof Kozlowski: > On 09/06/2022 15:57, Maya Matuszczyk wrote: > > czw., 9 cze 2022 o 13:56 Krzysztof Kozlowski > > napisał(a): > >> > >> The node names should be generic and DT schema expects certain pattern > >> (e.g. with key/button/switch). > >> > >> Signed-off-by: Krzysztof Kozlowski > >> --- > >> arch/arm64/boot/dts/rockchip/rk3308-evb.dts | 2 +- > >> .../boot/dts/rockchip/rk3326-odroid-go2.dts | 32 +++++++++---------- > >> .../boot/dts/rockchip/rk3328-nanopi-r2s.dts | 2 +- > >> arch/arm64/boot/dts/rockchip/rk3368-evb.dtsi | 2 +- > >> .../boot/dts/rockchip/rk3368-geekbox.dts | 2 +- > >> .../dts/rockchip/rk3368-orion-r68-meta.dts | 2 +- > >> .../boot/dts/rockchip/rk3368-px5-evb.dts | 2 +- > >> arch/arm64/boot/dts/rockchip/rk3368-r88.dts | 2 +- > >> .../boot/dts/rockchip/rk3399-firefly.dts | 2 +- > >> .../dts/rockchip/rk3399-gru-chromebook.dtsi | 2 +- > >> .../boot/dts/rockchip/rk3399-gru-kevin.dts | 2 +- > >> .../boot/dts/rockchip/rk3399-gru-scarlet.dtsi | 2 +- > >> .../boot/dts/rockchip/rk3399-khadas-edge.dtsi | 2 +- > >> .../boot/dts/rockchip/rk3399-nanopi-r4s.dts | 4 +-- > >> .../boot/dts/rockchip/rk3399-nanopi4.dtsi | 2 +- > >> .../boot/dts/rockchip/rk3399-orangepi.dts | 2 +- > >> .../boot/dts/rockchip/rk3399-pinebook-pro.dts | 4 +-- > >> .../boot/dts/rockchip/rk3399-roc-pc.dtsi | 2 +- > >> .../boot/dts/rockchip/rk3399-rockpro64.dtsi | 2 +- > >> .../boot/dts/rockchip/rk3399-sapphire.dtsi | 2 +- > >> .../boot/dts/rockchip/rk3566-pinenote.dtsi | 2 +- > >> 21 files changed, 38 insertions(+), 38 deletions(-) > >> > >> diff --git a/arch/arm64/boot/dts/rockchip/rk3308-evb.dts b/arch/arm64/boot/dts/rockchip/rk3308-evb.dts > >> index 9b4f855ea5d4..4b5413b12bfa 100644 > >> --- a/arch/arm64/boot/dts/rockchip/rk3308-evb.dts > >> +++ b/arch/arm64/boot/dts/rockchip/rk3308-evb.dts > >> @@ -75,7 +75,7 @@ gpio-keys { > >> pinctrl-names = "default"; > >> pinctrl-0 = <&pwr_key>; > >> > >> - power { > >> + power-key { hmm, it looks like all the others below are named key-power, while only this uses power-key ? > >> gpios = <&gpio0 RK_PA6 GPIO_ACTIVE_LOW>; > >> linux,code = ; > >> label = "GPIO Key Power"; > >> diff --git a/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts b/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts > >> index ea0695b51ecd..72328dd993ee 100644 > >> --- a/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts > >> +++ b/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts > >> @@ -71,82 +71,82 @@ gpio-keys { > >> * |------------------------------------------------| > >> */ > >> > >> - sw1 { > >> + switch-1 { > > Wouldn't it make more sense to rename this and all other > > renamed nodes in this dts into "button-dpad-up" or "button-1", > > as on the physical device those are buttons and the naming > > scheme of "sw" + number seems to be a carryover from > > downstream sources. The naming actually carries over from the device itself. In the schematics the relevant keys are also named sw1, sw2, etc. And I do believe it is way nicer when devicetree names correspond to the things you find in device schematics and not be named "arbitarily" to only conform to some schema ;-) So personally I'd actually prefer going with switch-sw1 (or button-sw1 if you prefer) as being able to just use the search function in schematic pdfs is a helpful tool. Heiko > Can be buttons. I assumed SW comes from some kind of switch. > I assume you mean only this Odroid Go2 DTS, because some other DTSes > (like EVB above) explicitly call it "Key Power". > > > Best regards, > Krzysztof >