From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C33FC433E0 for ; Mon, 25 May 2020 10:43:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 013F320812 for ; Mon, 25 May 2020 10:43:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389897AbgEYKnx (ORCPT ); Mon, 25 May 2020 06:43:53 -0400 Received: from gloria.sntech.de ([185.11.138.130]:52722 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389484AbgEYKnx (ORCPT ); Mon, 25 May 2020 06:43:53 -0400 Received: from ip5f5aa64a.dynamic.kabel-deutschland.de ([95.90.166.74] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jdAa8-0007fu-Cf; Mon, 25 May 2020 12:43:44 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Tiezhu Yang Cc: Kishon Vijay Abraham I , Vinod Koul , linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Xuefeng Li Subject: Re: [PATCH 1/2] phy: rockchip: Fix return value of inno_dsidphy_probe() Date: Mon, 25 May 2020 12:43:43 +0200 Message-ID: <2126910.YdF4jQdSac@diego> In-Reply-To: <1590379739-18729-1-git-send-email-yangtiezhu@loongson.cn> References: <1590379739-18729-1-git-send-email-yangtiezhu@loongson.cn> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Montag, 25. Mai 2020, 06:08:58 CEST schrieb Tiezhu Yang: > When call function devm_platform_ioremap_resource(), we should use IS_ERR() > to check the return value and return PTR_ERR() if failed. > > Fixes: b7535a3bc0ba ("phy/rockchip: Add support for Innosilicon MIPI/LVDS/TTL PHY") > Signed-off-by: Tiezhu Yang Reviewed-by: Heiko Stuebner