From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60AECC54EBE for ; Mon, 16 Jan 2023 16:30:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233120AbjAPQan (ORCPT ); Mon, 16 Jan 2023 11:30:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46492 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233258AbjAPQaE (ORCPT ); Mon, 16 Jan 2023 11:30:04 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 744812ED5A for ; Mon, 16 Jan 2023 08:17:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673885859; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=e31RvkaYoBXUi6IUkpSgeZzLhAlyWB0nDu0W8hJQeBU=; b=dJhgjS+Z6M9StFYfoc2vcJk9q2Y46fpVkwBdd581EiZRP4SkjZu/oQ3uYi/5YJgDrrJz1S 4SUF6EXi0K9QqhwumADlnDz8VfmBDC8DzdW48GSU7jvhMIt+Y1wO/E8uP6GxkpXS32I9IT xqSRFBAeKBQZCUTjPslDIuWBp203q8o= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-664-UHi9Bv3fMqiCIvuUMyr86A-1; Mon, 16 Jan 2023 11:17:35 -0500 X-MC-Unique: UHi9Bv3fMqiCIvuUMyr86A-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8E517857F40; Mon, 16 Jan 2023 16:17:35 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.23]) by smtp.corp.redhat.com (Postfix) with ESMTP id D4C8540C2004; Mon, 16 Jan 2023 16:17:34 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <2117829.1673884910@warthog.procyon.org.uk> To: Christoph Hellwig Cc: dhowells@redhat.com, Jens Axboe , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: Is there a reason why REQ_OP_READ has to be 0? MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2127556.1673885854.1@warthog.procyon.org.uk> Date: Mon, 16 Jan 2023 16:17:34 +0000 Message-ID: <2127557.1673885854@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Aha! The problem is that whilst aio, io_uring and cachefiles set IOCB_WRITE when giving a write op to the VFS, the write() syscall does not... David