From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67136C00454 for ; Mon, 9 Dec 2019 12:18:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 47950207FF for ; Mon, 9 Dec 2019 12:18:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727496AbfLIMSP (ORCPT ); Mon, 9 Dec 2019 07:18:15 -0500 Received: from cloudserver094114.home.pl ([79.96.170.134]:54893 "EHLO cloudserver094114.home.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727438AbfLIMSP (ORCPT ); Mon, 9 Dec 2019 07:18:15 -0500 Received: from 79.184.255.117.ipv4.supernova.orange.pl (79.184.255.117) (HELO kreacher.localnet) by serwer1319399.home.pl (79.96.170.134) with SMTP (IdeaSmtpServer 0.83.320) id 70099c35fdbc405c; Mon, 9 Dec 2019 13:18:12 +0100 From: "Rafael J. Wysocki" To: Geert Uytterhoeven Cc: Jens Axboe , Ming Lei , "Rafael J . Wysocki" , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] block: Make request_queue.rpm_status an enum Date: Mon, 09 Dec 2019 13:18:12 +0100 Message-ID: <2128344.f0oqsL5Bda@kreacher> In-Reply-To: <20191206132350.29040-1-geert+renesas@glider.be> References: <20191206132350.29040-1-geert+renesas@glider.be> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, December 6, 2019 2:23:50 PM CET Geert Uytterhoeven wrote: > request_queue.rpm_status is assigned values of the rpm_status enum only, > so reflect that in its type. > > Signed-off-by: Geert Uytterhoeven Acked-by: Rafael J. Wysocki > --- > Perhaps this was done to avoid the need to #include ? > Let's see what kbuild has to report about this... > --- > include/linux/blkdev.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h > index 397bb9bc230b6349..6419cd9523c370f8 100644 > --- a/include/linux/blkdev.h > +++ b/include/linux/blkdev.h > @@ -466,7 +466,7 @@ struct request_queue { > > #ifdef CONFIG_PM > struct device *dev; > - int rpm_status; > + enum rpm_status rpm_status; > unsigned int nr_pending; > #endif > >