From: Stephen Cameron <smcameron@yahoo.com>
To: akpm@osdl.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: cciss: fix error reporting for SG_IO
Date: Sat, 25 Aug 2007 21:15:07 -0700 (PDT) [thread overview]
Message-ID: <213452.45405.qm@web33010.mail.mud.yahoo.com> (raw)
> > This fixes a problem with the way cciss was filling out the "errors"
> > field of the request structure upon completion of requests.
> > Previously, it just put a 1 or a 0 in there and used the negation
> > of this as the uptodate parameter to one of the functions in the
> > block layer, being a block device. For the SG_IO ioctl, this was not
> > sufficient, and we noticed that, for example, sg_turs from sg3_utils
> > did not correctly detect problems due to cciss having set rq->errors
> > incorrectly.
>
> Do we think this problem is sufficiently serious to merit merging
> this (largeish) patch into 2.6.23?
>
> I'm thinking "no", but that might be wrong...
Without saying too much (I hope), if you want multipath i/o to cciss
devices to work which depend on device mapper, (which I can't say what
specific device(s) match that description without getting myself into
trouble) then you want this patch. If my understanding is correct, then
some DM multipath stuff depends on TUR response to know if a path is
failed. If you don't care about that, then you can skip it.
-- steve
____________________________________________________________________________________
Moody friends. Drama queens. Your life? Nope! - their life, your story. Play Sims Stories at Yahoo! Games.
http://sims.yahoo.com/
reply other threads:[~2007-08-26 4:21 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=213452.45405.qm@web33010.mail.mud.yahoo.com \
--to=smcameron@yahoo.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox