From: "Heiko Stübner" <heiko@sntech.de>
To: palmer@rivosinc.com, Conor Dooley <conor@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
christoph.muellner@vrull.eu, ajones@ventanamicro.com
Subject: Re: [PATCH 1/2] RISC-V: fix ordering of Zbb extension
Date: Thu, 09 Feb 2023 00:26:50 +0100 [thread overview]
Message-ID: <2135493.irdbgypaU6@diego> (raw)
In-Reply-To: <C32D5495-F772-4887-9CAD-66206ECCFC3F@kernel.org>
Am Donnerstag, 9. Februar 2023, 00:20:10 CET schrieb Conor Dooley:
> Hey Heiko,
>
> On 8 February 2023 22:53:27 GMT, Heiko Stuebner <heiko@sntech.de> wrote:
> >From: Heiko Stuebner <heiko.stuebner@vrull.eu>
> >
> >As Andrew reported,
> > Zb* comes after Zi* according 27.11 "Subset Naming Convention"
> >so fix the ordering accordingly.
> >
> >Reported-by: Andrew Jones <ajones@ventanamicro.com>
> >Signed-off-by: Heiko Stuebner <heiko.stuebner@vrull.eu>
>
> The whole "getting it wrong immediately after fixing it up" ;)
>
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
I'm still hopefully that I'll learn at some point that "b" comes after "i",
at least with riscv extensions. Decades of sorting the other way around are
hard to break :-D .
> >---
> > arch/riscv/kernel/cpu.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/arch/riscv/kernel/cpu.c b/arch/riscv/kernel/cpu.c
> >index 420228e219f7..8400f0cc9704 100644
> >--- a/arch/riscv/kernel/cpu.c
> >+++ b/arch/riscv/kernel/cpu.c
> >@@ -185,9 +185,9 @@ arch_initcall(riscv_cpuinfo_init);
> > * New entries to this struct should follow the ordering rules described above.
> > */
> > static struct riscv_isa_ext_data isa_ext_arr[] = {
> >- __RISCV_ISA_EXT_DATA(zbb, RISCV_ISA_EXT_ZBB),
> > __RISCV_ISA_EXT_DATA(zicbom, RISCV_ISA_EXT_ZICBOM),
> > __RISCV_ISA_EXT_DATA(zihintpause, RISCV_ISA_EXT_ZIHINTPAUSE),
> >+ __RISCV_ISA_EXT_DATA(zbb, RISCV_ISA_EXT_ZBB),
> > __RISCV_ISA_EXT_DATA(sscofpmf, RISCV_ISA_EXT_SSCOFPMF),
> > __RISCV_ISA_EXT_DATA(sstc, RISCV_ISA_EXT_SSTC),
> > __RISCV_ISA_EXT_DATA(svinval, RISCV_ISA_EXT_SVINVAL),
>
next prev parent reply other threads:[~2023-02-08 23:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 22:53 [PATCH 0/2] Small fixups for the Zbb string functions Heiko Stuebner
2023-02-08 22:53 ` [PATCH 1/2] RISC-V: fix ordering of Zbb extension Heiko Stuebner
2023-02-08 23:20 ` Conor Dooley
2023-02-08 23:26 ` Heiko Stübner [this message]
2023-02-09 8:25 ` Andrew Jones
2023-02-09 9:03 ` Conor Dooley
2023-02-09 9:28 ` Andrew Jones
2023-02-09 8:23 ` Andrew Jones
2023-02-08 22:53 ` [PATCH 2/2] RISC-V: improve string-function assembly Heiko Stuebner
2023-02-09 8:25 ` Andrew Jones
2023-02-10 20:49 ` [PATCH 0/2] Small fixups for the Zbb string functions Conor Dooley
2023-02-22 15:00 ` patchwork-bot+linux-riscv
2023-02-28 20:51 ` (subset) " Palmer Dabbelt
2023-02-28 21:11 ` patchwork-bot+linux-riscv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2135493.irdbgypaU6@diego \
--to=heiko@sntech.de \
--cc=ajones@ventanamicro.com \
--cc=christoph.muellner@vrull.eu \
--cc=conor@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@rivosinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox