Re: [PATCH 0/4]nbd: fixes for nbd

Markus Pargmann
2016-05-30T12:27:13Z

[-- Attachment #1: Type: text/plain, Size: 1229 bytes --]

Hi,

On Tuesday 24 May 2016 14:26:24 Pranay Kr. Srivastava wrote:
> This patch series fixes the following
>
> 1) fix might_sleep warning on socket shutdown:
> Fix sock_shutdown to avoid calling kernel_sock_shutdown
> while holding spin_lock.
>
> 2)fix various coding standard warnings
> Make shutdown get called in a process context instead, using
> system_wq.
>
> 3) make nbd device wait for its users.
> When a timeout or error occurs then nbd driver simply kills
> the block device. Many filesystem(s) example ext2/ext3 don't
> expect their buffer heads to disappear like that. Fix this
> by making nbd device wait for its users.
>
> 4) use device_attr macros for sysfs attribute
> use DEVICE_ATTR_RO for sysfs pid attribute.

Thanks, I applied patches 2 and 4. For the next version please add a
"nbd: " prefix to the other patches.

Best Regards,

Markus

--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]