From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752534AbcF1Qcv (ORCPT ); Tue, 28 Jun 2016 12:32:51 -0400 Received: from gloria.sntech.de ([95.129.55.99]:54720 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752023AbcF1Qcu (ORCPT ); Tue, 28 Jun 2016 12:32:50 -0400 From: Heiko Stuebner To: Andi Shyti , Michael Turquette Cc: andi.shyti@gmail.com, Jeffy Chen , Xing Zheng , Stephen Boyd , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] clk: clk-rk3*: set CLK_IS_CRITICAL flag to critical clocks Date: Tue, 28 Jun 2016 18:32:30 +0200 Message-ID: <2136865.gUkObTo8M5@phil> User-Agent: KMail/4.14.10 (Linux/4.3.0-1-amd64; KDE/4.14.14; x86_64; ; ) In-Reply-To: <20160628160922.GN424@jack.zhora.eu> References: <1467125137-25999-1-git-send-email-andi@etezian.org> <29356205.Gk5k6xKH6K@phil> <20160628160922.GN424@jack.zhora.eu> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andi, Am Mittwoch, 29. Juni 2016, 01:09:22 schrieb Andi Shyti: > > > RK2928_CLKSEL_CON(0), 14, 2, MFLAGS, 8, 5, DFLAGS), > > > > > > - GATE(ACLK_CPU, "aclk_cpu", "aclk_cpu_src", CLK_IGNORE_UNUSED, > > > + GATE(ACLK_CPU, "aclk_cpu", "aclk_cpu_src", > > > + CLK_IS_CRITICAL | CLK_IGNORE_UNUSED, > > > > - you'll never need both critical and ignore_unused > > Indeed I was unsure whether I should remove the > CLK_IGNORE_UNUSED, but then I decided to leave it because that's > basically what the driver is currently doing. Thanks! > > > Happens in some more cases below, but otherwise looks ok ... as written > > in the cover-letter I'm just still trying to make up my mind if it's > > worth waiting for the handoff mechanism. > > You mean something similar (*)? I actually mean https://lkml.org/lkml/2016/2/11/694 which received additional comments somewhere and Mike said he wanted to repost. Heiko