From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB0A5C27C7C for ; Fri, 20 Jan 2023 09:39:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230010AbjATJjO (ORCPT ); Fri, 20 Jan 2023 04:39:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229657AbjATJjN (ORCPT ); Fri, 20 Jan 2023 04:39:13 -0500 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D51544BC6; Fri, 20 Jan 2023 01:39:10 -0800 (PST) Received: from ip5b412258.dynamic.kabel-deutschland.de ([91.65.34.88] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pInrA-0002gP-SZ; Fri, 20 Jan 2023 10:38:44 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Lars Povlsen , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Thierry Reding , Jonathan Hunter , Andreas =?ISO-8859-1?Q?F=E4rber?= , Manivannan Sadhasivam , Alim Akhtar , Tony Huang , Li-hao Kuo , Maxime Ripard , Adrian Hunter , Masahiro Yamada , Markus Pargmann , Wolfram Sang , Jaehoon Chung , linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-tegra@vger.kernel.org, linux-actions@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Krzysztof Kozlowski Cc: Krzysztof Kozlowski Subject: Re: [PATCH 2/2] dt-bindings: mmc: correct pwrseq node names Date: Fri, 20 Jan 2023 10:38:43 +0100 Message-ID: <2138388.Mh6RI2rZIc@diego> In-Reply-To: <20230120085722.171965-2-krzysztof.kozlowski@linaro.org> References: <20230120085722.171965-1-krzysztof.kozlowski@linaro.org> <20230120085722.171965-2-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Freitag, 20. Januar 2023, 09:57:22 CET schrieb Krzysztof Kozlowski: > Node names should be generic and should not contain underscores. > > Signed-off-by: Krzysztof Kozlowski > --- > Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml | 2 +- > Documentation/devicetree/bindings/mmc/mmc-pwrseq-sd8787.yaml | 2 +- > Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml > index 911a5996e099..588be73168fa 100644 > --- a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml > +++ b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml > @@ -41,7 +41,7 @@ additionalProperties: false > examples: > - | > #include > - sdhci0_pwrseq { > + pwrseq { [applicable for all 3 examples] hmm, power-sequences are not necessarily tied to an address and I guess it will be very much a common case to have multiple ones on a system. So might it be better to follow other patterns (like leds) to number them or suggest a "foo-pwrseq" / "pwrseq-foo"? Heiko > compatible = "mmc-pwrseq-emmc"; > reset-gpios = <&gpio1 12 GPIO_ACTIVE_LOW>; > }; > diff --git a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-sd8787.yaml b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-sd8787.yaml > index 3397dbff88c2..b35e00e8c65e 100644 > --- a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-sd8787.yaml > +++ b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-sd8787.yaml > @@ -35,7 +35,7 @@ additionalProperties: false > examples: > - | > #include > - wifi_pwrseq: wifi_pwrseq { > + pwrseq { > compatible = "mmc-pwrseq-sd8787"; > powerdown-gpios = <&twl_gpio 0 GPIO_ACTIVE_LOW>; > reset-gpios = <&twl_gpio 1 GPIO_ACTIVE_LOW>; > diff --git a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml > index 64e3644eefeb..00feaafc1063 100644 > --- a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml > +++ b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml > @@ -55,7 +55,7 @@ additionalProperties: false > examples: > - | > #include > - sdhci0_pwrseq { > + pwrseq { > compatible = "mmc-pwrseq-simple"; > reset-gpios = <&gpio1 12 GPIO_ACTIVE_LOW>; > clocks = <&clk_32768_ck>; >