From: Michal Marek <mmarek@suse.com>
To: Cheah Kok Cheong <thrust73@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scripts: checkincludes: add exit message for no duplicates found
Date: Mon, 19 Dec 2016 11:47:47 +0100 [thread overview]
Message-ID: <213a88cd-de9c-d7f2-f765-1e8d35b569cf@suse.com> (raw)
In-Reply-To: <1482064519-4352-1-git-send-email-thrust73@gmail.com>
On 2016-12-18 13:35, Cheah Kok Cheong wrote:
> If no duplicates found, inform user.
>
> Signed-off-by: Cheah Kok Cheong <thrust73@gmail.com>
> ---
> scripts/checkincludes.pl | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/scripts/checkincludes.pl b/scripts/checkincludes.pl
> index 97b2c61..2bf234c 100755
> --- a/scripts/checkincludes.pl
> +++ b/scripts/checkincludes.pl
> @@ -37,6 +37,13 @@ if ($#ARGV >= 1) {
> }
> }
>
> +my $dup_counter = 0;
> +
> +sub nodup_count {
> + ++$dup_counter;
> + return;
> +}
I don't think it's necessary to have a function only to increment a
variable.
Michal
next prev parent reply other threads:[~2016-12-19 10:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-18 12:35 [PATCH] scripts: checkincludes: add exit message for no duplicates found Cheah Kok Cheong
2016-12-19 10:47 ` Michal Marek [this message]
2016-12-20 9:10 ` Cheah Kok Cheong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=213a88cd-de9c-d7f2-f765-1e8d35b569cf@suse.com \
--to=mmarek@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=thrust73@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).