From: Heiko Stuebner <heiko@sntech.de>
To: Johan Jonker <jbx6244@gmail.com>
Cc: robh+dt@kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] arm64: dts: rockchip: add core devicetree for rk3318
Date: Fri, 17 Apr 2020 13:05:27 +0200 [thread overview]
Message-ID: <2141402.AJMLQ3pQEO@phil> (raw)
In-Reply-To: <20200417105739.3718-1-jbx6244@gmail.com>
Hi Johan,
Am Freitag, 17. April 2020, 12:57:39 CEST schrieb Johan Jonker:
> The rk3318 is basically a rk3328 with improved gpu,
> so add a dtsi based on that.
>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
Please don't add dangling dtsi files.
I'd expect at least a board dts to actually use that and
also the updated gpu node.
From a cursory glance it looks like it gets upgraded from
450-MP2 to 450MP3 or so, so that would at least mean
another set of interrupts.
Heiko
> ---
> arch/arm64/boot/dts/rockchip/rk3318.dtsi | 3 +++
> 1 file changed, 3 insertions(+)
> create mode 100644 arch/arm64/boot/dts/rockchip/rk3318.dtsi
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3318.dtsi b/arch/arm64/boot/dts/rockchip/rk3318.dtsi
> new file mode 100644
> index 000000000..a32f771bc
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3318.dtsi
> @@ -0,0 +1,3 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +
> +#include "rk3328.dtsi"
>
next prev parent reply other threads:[~2020-04-17 11:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 10:57 [RFC PATCH] arm64: dts: rockchip: add core devicetree for rk3318 Johan Jonker
2020-04-17 11:05 ` Heiko Stuebner [this message]
2020-04-17 11:51 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2141402.AJMLQ3pQEO@phil \
--to=heiko@sntech.de \
--cc=devicetree@vger.kernel.org \
--cc=jbx6244@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox