From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757331AbdJQNHl (ORCPT ); Tue, 17 Oct 2017 09:07:41 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:43438 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756056AbdJQNHi (ORCPT ); Tue, 17 Oct 2017 09:07:38 -0400 X-AuditID: b6c32a39-a6fff7000000109f-24-59e60098bff4 From: Bartlomiej Zolnierkiewicz To: Himanshu Jha Cc: gustavo@embeddedor.com, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] video: fbdev: pxa3xx_gcu: Use setup_timer and mod_timer Date: Tue, 17 Oct 2017 15:07:33 +0200 Message-id: <2142686.yESyXOL10f@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <1506629791-11695-1-git-send-email-himanshujha199640@gmail.com> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset="us-ascii" X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrAIsWRmVeSWpSXmKPExsWy7bCmru4MhmeRBld/M1ls3aNqMW1NC6vF ib4PrBaXd81hc2DxWHdQ1WPnrLvsHp83yQUwR3HZpKTmZJalFunbJXBlLDvSyVjwiKXi2/2/ 7A2Mj5i7GDk5JARMJJ72LGLsYuTiEBLYwSjxYvFvKOc7o8SHZdcZYaoOLnrOApHYwCjRs2oD VNVXRok1l3+ygFSxCVhJTGxfBdYhIqAn8ailEyzOLBAu0frvACuILSzgI7H322+wGhYBVYlN j38zgdi8ApoS/Z/OgNWLCnhJbNnXDhbnBKpf2nmFBaJGUOLH5HtQM+Ul9u2fygph60icPbYO 7CAJgSlsEs2THjBBnO0isXTOc6gXhCVeHd/C3sXIAWRLS1w6agsRns4osf23BETvZkaJVbsn sEMkrCUOH78ItYBP4t3XHlaIXl6JjjYhCNNDYvcuC4hqR4mFt2DBOJ9R4lvLA8YJjLKzkJw9 C8nZs5CcvYCReRWjWGpBcW56arFhgalecWJucWleul5yfu4mRnC8a1nuYDx2zucQowAHoxIP b8ahJ5FCrIllxZW5hxglOJiVRHgl/jyNFOJNSaysSi3Kjy8qzUktPsQozcGiJM4ruv5ahJBA emJJanZqakFqEUyWiYNTqoExgc92O4/k45WfH77UbPr240mCYqfZvSPlB6vWN9xRujDPPzIk b83Rb956flu1t/868oxt3qxJLesL2j7/k2ww7VpoHjONP2nlkgwvrmSfC6ZvL//aszXT038q h6i58hLvmhPPJ74XSOUv5X20e+dq1z9+4Y/PTur+dfD5yYTCCMG//1ec6u5QVmIpzkg01GIu Kk4EADdnn+DzAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrFLMWRmVeSWpSXmKPExsVy+t9jQd3pDM8iDVZ1S1ls3aNqMW1NC6vF ib4PrBaXd81hc2DxWHdQ1WPnrLvsHp83yQUwR3HZpKTmZJalFunbJXBlLDvSyVjwiKXi2/2/ 7A2Mj5i7GDk5JARMJA4ues7SxcjFISSwjlHi/MpFjBDOV0aJO9s6WECq2ASsJCa2r2IEsUUE 9CQetXSCxZkFwiW+nP/KCmILC/hI7P32G6yGRUBVYtPj30wgNq+ApkT/pzNg9aICXhJb9rWD xTmB6pd2XoHavJBRYsODM2wQDYISPybfg1ogL7Fv/1RWCFtLYv3O40wTGPlnISmbhaRsFpKy BYzMqxglUwuKc9Nzi40KDPNSy/WKE3OLS/PS9ZLzczcxAkN022Gtvh2M95fEH2IU4GBU4uE9 cORJpBBrYllxZe4hRgkOZiURXok/TyOFeFMSK6tSi/Lji0pzUosPMUpzsCiJ897OOxYpJJCe WJKanZpakFoEk2Xi4JRqYBR0ObytTpD3zDZpBf3X85aYfMpZ/uXBDJ8ZRQx3p1x4Nfm72BqX B4IrCrbNsbraX2f66N05WwudhvS0o9s4bk4/uCj6V9p3/r1yMS8PGZyuj1rxrI8pJyD9/RWO LxEz369b71S/y3iWX8KB+UX3ls7s+3shZOrZmA/Pj/W3OM76HCNwXa/IJe+UEktxRqKhFnNR cSIA08I7L00CAAA= X-CMS-MailID: 20171017130735epcas1p2254d2289e807df9ce453904d145f39f7 X-Msg-Generator: CA X-Sender-IP: 182.195.42.142 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 101P X-CMS-RootMailID: 20170928201649epcas2p396ef5c6a3bca9eee120f9800c3a22b43 X-RootMTR: 20170928201649epcas2p396ef5c6a3bca9eee120f9800c3a22b43 References: <1506629791-11695-1-git-send-email-himanshujha199640@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, September 29, 2017 01:46:31 AM Himanshu Jha wrote: > Use setup_timer and mod_timer API instead of structure assignments. > > This is done using Coccinelle and semantic patch used > for this as follows: > > @@ > expression x,y,z,a,b; > @@ > > -init_timer (&x); > +setup_timer (&x, y, z); > +mod_timer (&a, b); > -x.function = y; > -x.data = z; > -x.expires = b; > -add_timer(&a); > > Signed-off-by: Himanshu Jha Patch queued for 4.15, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics