* [PATCH] frv: Remove duplicate output of .exit.data
@ 2007-10-12 15:40 Maciej W. Rozycki
2007-10-13 9:17 ` David Howells
0 siblings, 1 reply; 4+ messages in thread
From: Maciej W. Rozycki @ 2007-10-12 15:40 UTC (permalink / raw)
To: David Howells, Andrew Morton; +Cc: linux-kernel
When CONFIG_DEBUG_INFO is unset the input .exit.data sections are copied
twice to vmlinux. Remove the copy made to .init.text and keep one in
.data only.
Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
---
It looks like an accidental mistake to me. It applies to current Linus's
2.6.23.
Please consider,
Maciej
patch-mips-2.6.23-rc5-20070904-frv-exit-data-0
diff -up --recursive --new-file linux-mips-2.6.23-rc5-20070904.macro/arch/frv/kernel/vmlinux.lds.S linux-mips-2.6.23-rc5-20070904/arch/frv/kernel/vmlinux.lds.S
--- linux-mips-2.6.23-rc5-20070904.macro/arch/frv/kernel/vmlinux.lds.S 2007-09-04 04:55:18.000000000 +0000
+++ linux-mips-2.6.23-rc5-20070904/arch/frv/kernel/vmlinux.lds.S 2007-10-11 22:53:09.000000000 +0000
@@ -30,7 +30,6 @@ SECTIONS
#ifndef CONFIG_DEBUG_INFO
*(.init.text)
*(.exit.text)
- *(.exit.data)
*(.exitcall.exit)
#endif
}
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] frv: Remove duplicate output of .exit.data
2007-10-12 15:40 [PATCH] frv: Remove duplicate output of .exit.data Maciej W. Rozycki
@ 2007-10-13 9:17 ` David Howells
2007-10-15 15:27 ` Maciej W. Rozycki
0 siblings, 1 reply; 4+ messages in thread
From: David Howells @ 2007-10-13 9:17 UTC (permalink / raw)
To: Maciej W. Rozycki; +Cc: dhowells, Andrew Morton, linux-kernel
Maciej W. Rozycki <macro@linux-mips.org> wrote:
> When CONFIG_DEBUG_INFO is unset the input .exit.data sections are copied
> twice to vmlinux. Remove the copy made to .init.text and keep one in
> .data only.
No, they aren't. I believe the linker only makes one copy of each section,
and once a copy is inserted, all other attempts to make a copy of it are
ignored.
NAK.
David
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] frv: Remove duplicate output of .exit.data
2007-10-13 9:17 ` David Howells
@ 2007-10-15 15:27 ` Maciej W. Rozycki
2007-10-15 20:43 ` David Howells
0 siblings, 1 reply; 4+ messages in thread
From: Maciej W. Rozycki @ 2007-10-15 15:27 UTC (permalink / raw)
To: David Howells; +Cc: Andrew Morton, linux-kernel
On Sat, 13 Oct 2007, David Howells wrote:
> > When CONFIG_DEBUG_INFO is unset the input .exit.data sections are copied
> > twice to vmlinux. Remove the copy made to .init.text and keep one in
> > .data only.
>
> No, they aren't. I believe the linker only makes one copy of each section,
> and once a copy is inserted, all other attempts to make a copy of it are
> ignored.
Fair enough -- a quick test shows you are right. Wouldn't it deserve a
comment, though? I know hardly anybody dares looking into these scripts,
;-) but those who do, may not be sure this setup is intentional.
Maciej
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] frv: Remove duplicate output of .exit.data
2007-10-15 15:27 ` Maciej W. Rozycki
@ 2007-10-15 20:43 ` David Howells
0 siblings, 0 replies; 4+ messages in thread
From: David Howells @ 2007-10-15 20:43 UTC (permalink / raw)
To: Maciej W. Rozycki; +Cc: dhowells, Andrew Morton, linux-kernel
Maciej W. Rozycki <macro@linux-mips.org> wrote:
> Fair enough -- a quick test shows you are right. Wouldn't it deserve a
> comment, though? I know hardly anybody dares looking into these scripts,
> ;-) but those who do, may not be sure this setup is intentional.
Probably.
David
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-10-15 20:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-12 15:40 [PATCH] frv: Remove duplicate output of .exit.data Maciej W. Rozycki
2007-10-13 9:17 ` David Howells
2007-10-15 15:27 ` Maciej W. Rozycki
2007-10-15 20:43 ` David Howells
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox