From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756699AbcIVM6l (ORCPT ); Thu, 22 Sep 2016 08:58:41 -0400 Received: from mout.kundenserver.de ([217.72.192.75]:61488 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751263AbcIVM6g (ORCPT ); Thu, 22 Sep 2016 08:58:36 -0400 From: Arnd Bergmann To: David Miller Cc: maheshb@google.com, dsa@cumulusnetworks.com, edumazet@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ipvlan: fix building without netfilter Date: Thu, 22 Sep 2016 14:58:24 +0200 Message-ID: <2147423.Poz9bNzMml@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <20160922.083205.2034005377472668654.davem@davemloft.net> References: <20160922094130.2154824-1-arnd@arndb.de> <20160922.083205.2034005377472668654.davem@davemloft.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:XyQUltkZrow4sTh9IwkUITGcOpmw55rjIEbU13QoLJyBIFUSkoq iquiH8+1AVPelpu7/ajBn83pSPZvnKch5P5F/qA24nC9LZELqtAAr6dimawWBWeewIHCuw9 lOVUOxRNQirDXQPQuIW6JSLoOHVa2tNHj9u18WX02TcFUbw72iuXC0MhkhopC5gyUOcShYR bVlEcSp2VjJonT+/Ymgvg== X-UI-Out-Filterresults: notjunk:1;V01:K0:z+mCuJlCo0c=:9nG+6GZDV23pC+91sXKvxD LQghx6cEQxK50/YqsRuneTVBezaumS8dqyb8cjXT4k6qKd4m1g4X8cT8x9TAXh7PjWVIPcrXd ROuU8gtc17Yb1yIPvt2V5yawgGShLg5C1M8gYeEe6KtuAFaxIOlfE4YRRe5Ahvb82c9O//pvP 8tS/vXzpXYqbO8XsbaQC77gvV46GzE+Hlw4nUmuTJkP9DZiUIdNV2b3lvRTskGGTjKB9JNRF5 zd0dJqEIAVXsN6r7FT8bNxxhBUgA2iB58/5xRDbDzym9xYmPZS2treTPZkb78NCywa+oQvjLJ 9TXy2UC2Hz2bjt6AkKlJAFJ7D9iBpHgZ6D3144vzO23zTlQVITeXdwmg+7XACUudO8TPALFkS U57kckFXM2oNZoiQiLpSS0FK/EJyqG4Tn9qQy0fzghgucA5eYLCwy16Nu+kohVnthyZw0Bwpb JrE0QOryKXSsiijTu7LhEd2h9+rFsWdWWzTFgLTUcsiAp+WfwZaTYTxDKorbPSeDG4DkoPWYU zcLm1QBvWUHZkhPnWEnKsmjTtsYPaV2IGCUQS8Kidt3QUjWhSUuIOWOZAVo2aiGFFCzV8zu2m cAHQvHlpzmxuKZRXaKsrxt3naN0xQpAV6VFfYaNbVFo/MxIMnSfEfHrR/SjLkuqy2lFnqKe5t wB+nNHL4Vf9p5hOQIkaGq1HcddfdnuyuemJxLTBZeO1Mbth/IIU+xsFCKz8dKoXlOJvrMJPR2 EyeUaw9A7oYA05Rv Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, September 22, 2016 8:32:05 AM CEST David Miller wrote: > From: Arnd Bergmann > Date: Thu, 22 Sep 2016 11:40:52 +0200 > > > The new l3s mode in ipvlan relies on netfilter interfaces, but > > the ipvlan driver can be configured when CONFIG_NETFILTER is disabled, > > leading to a build error: > > > > drivers/net/ipvlan/ipvlan.h:132:22: error: 'struct nf_hook_state' declared inside parameter list will not be visible outside of this definition or declaration [-Werror] > > drivers/net/ipvlan/ipvlan_main.c:14:27: error: array type has incomplete element type 'struct nf_hook_ops' > > ... > > > > This adds a forward declaration for struct nf_hook_state, and hides > > the newly added l3s code in an #ifdef. > > > > Fixes: 4fbae7d83c98 ("ipvlan: Introduce l3s mode") > > Signed-off-by: Arnd Bergmann > > I'm pretty sure I applied a Kconfig patch that added the > necessary dependency. Yes, I see the fix cf714ac147e0 ("ipvlan: Fix dependency issue") now, and can confirm that today's linux-next works without my patch, thanks! Arnd