From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F5913845A2 for ; Tue, 31 Mar 2026 06:27:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774938435; cv=none; b=fFTSDxD4cWHB6Ls3uwmOKLy9SiYu5IvGooIAn6mLR+Y8mS36tP6q6+X1ZpKSKfsjGme1N8NUVyjxNIkCDNbFuqlz54Xo4IoovOVv3WLAlvUoY0wt3JDfJMdEtHyak15e3T6FblUgSJFphcq1Hn8qN9JGDyLDBU9j0n/1OPE7pE0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774938435; c=relaxed/simple; bh=29C5udUBxO8gSefMlpR8R20+wCo/QDid+UWJwd5ur54=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=a6dN5bHA3PGBGDEe9x/N00uUE/NgpXiX/vRjK9i3BlhbvwsiVCTEYwX0fFyKo/8bEIhqUOKF3ltY6iumjU4Ra8IXQ8W8DsBArpWV+oBHX89ivI2Q8Toggd+ET//kGUXCiwtldwf1WS/fnA96FcGuNQOSU53JJQsUc8v+1owLMVU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=v/lAwbIC; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=PKqHkUWP; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=v/lAwbIC; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=PKqHkUWP; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="v/lAwbIC"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="PKqHkUWP"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="v/lAwbIC"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="PKqHkUWP" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A487E5BE93; Tue, 31 Mar 2026 06:27:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1774938432; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=hhP7i2cWQDIIFHNdX6ILKwrN6C18zchEHCGzRCfvmbs=; b=v/lAwbICLIZvEMjQ/bFibQnGLCTKrriY2Sz2U1CdMpzOPVkH3xmakmeVdxKjBnOytngq+R jN9pKp2serFmxXqMOBRYAmXFF72iQc0sEie2uumqDv0JVPyu69mu2NCeHRu3cvpfhV36ZB AvySCGHp3kzu+1xT0UBWSgX/C1GIbAc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1774938432; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=hhP7i2cWQDIIFHNdX6ILKwrN6C18zchEHCGzRCfvmbs=; b=PKqHkUWPrxZ/0QDxv1YCXf5gWyO9XO0FGzvUndBbEioC4ZjUfdbfPg4nds2WLTYxqaFVoN qBrHApRLnKgFsqCA== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="v/lAwbIC"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=PKqHkUWP DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1774938432; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=hhP7i2cWQDIIFHNdX6ILKwrN6C18zchEHCGzRCfvmbs=; b=v/lAwbICLIZvEMjQ/bFibQnGLCTKrriY2Sz2U1CdMpzOPVkH3xmakmeVdxKjBnOytngq+R jN9pKp2serFmxXqMOBRYAmXFF72iQc0sEie2uumqDv0JVPyu69mu2NCeHRu3cvpfhV36ZB AvySCGHp3kzu+1xT0UBWSgX/C1GIbAc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1774938432; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=hhP7i2cWQDIIFHNdX6ILKwrN6C18zchEHCGzRCfvmbs=; b=PKqHkUWPrxZ/0QDxv1YCXf5gWyO9XO0FGzvUndBbEioC4ZjUfdbfPg4nds2WLTYxqaFVoN qBrHApRLnKgFsqCA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 6ADE84A0A2; Tue, 31 Mar 2026 06:27:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id yoqfGEBpy2klGgAAD6G6ig (envelope-from ); Tue, 31 Mar 2026 06:27:12 +0000 Message-ID: <21479f6d-80c1-4f46-8a41-e50a2d564a94@suse.de> Date: Tue, 31 Mar 2026 08:27:11 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH drm-misc-next v4 0/4] drm: verisilicon: convert drm_format to vs_format in atomic_check To: Icenowy Zheng , Maarten Lankhorst , Maxime Ripard , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Icenowy Zheng References: <20260331060126.1291966-1-zhengxingda@iscas.ac.cn> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: <20260331060126.1291966-1-zhengxingda@iscas.ac.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_TO(0.00)[iscas.ac.cn,linux.intel.com,kernel.org,gmail.com,ffwll.ch]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; RCPT_COUNT_SEVEN(0.00)[8]; MID_RHS_MATCH_FROM(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCVD_TLS_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,suse.com:url,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received,2a07:de40:b281:104:10:150:64:97:from]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Queue-Id: A487E5BE93 X-Spam-Flag: NO X-Spam-Score: -4.51 X-Spam-Level: Hi, I only looked briefly over the update, but it seems good now. Best regards Thomas Am 31.03.26 um 08:01 schrieb Icenowy Zheng: > This patchset tries to move the process of converting drm_format to > vs_format into plane's atomic_check callback (instead of the > atomic_commit one, which the process currently sits) for more proper > error handling (because atomic_commit cannot fail). > > In addition, because of the original flow of primary plane's > atomic_check seems to be flawed, it's also updated before filling > vs_format is added there. > > Icenowy Zheng (4): > drm: verisilicon: make vs_format conversion function return int > drm: verisilicon: subclass drm_plane_state > drm: verisilicon: call atomic helper's plane state check even if no > CRTC > drm: verisilicon: fill plane's vs_format in atomic_check > > drivers/gpu/drm/verisilicon/vs_plane.c | 54 ++++++++++++++++++- > drivers/gpu/drm/verisilicon/vs_plane.h | 18 ++++++- > .../gpu/drm/verisilicon/vs_primary_plane.c | 48 ++++++++++------- > 3 files changed, 98 insertions(+), 22 deletions(-) > -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)