Re: [PATCH drm-misc-next v4 0/4] drm: verisilicon: convert drm_format to vs_format in atomic_check

Icenowy Zheng
2026-05-02T13:47:44Z

在 2026-03-31二的 08:27 +0200，Thomas Zimmermann写道：
> Hi,
>
> I only looked briefly over the update, but it seems good now.

Could you have a more thorough look on this patchset (and if possible,
apply it)?

Thanks
Icenowy

>
> Best regards
> Thomas
>
>
> Am 31.03.26 um 08:01 schrieb Icenowy Zheng:
> > This patchset tries to move the process of converting drm_format to
> > vs_format into plane's atomic_check callback (instead of the
> > atomic_commit one, which the process currently sits) for more
> > proper
> > error handling (because atomic_commit cannot fail).
> >
> > In addition, because of the original flow of primary plane's
> > atomic_check seems to be flawed, it's also updated before filling
> > vs_format is added there.
> >
> > Icenowy Zheng (4):
> >    drm: verisilicon: make vs_format conversion function return int
> >    drm: verisilicon: subclass drm_plane_state
> >    drm: verisilicon: call atomic helper's plane state check even if
> > no
> >      CRTC
> >    drm: verisilicon: fill plane's vs_format in atomic_check
> >
> >   drivers/gpu/drm/verisilicon/vs_plane.c        | 54
> > ++++++++++++++++++-
> >   drivers/gpu/drm/verisilicon/vs_plane.h        | 18 ++++++-
> >   .../gpu/drm/verisilicon/vs_primary_plane.c    | 48 ++++++++++----
> > ---
> >   3 files changed, 98 insertions(+), 22 deletions(-)
> >