From: Richard Weinberger <richard@nod.at>
To: Colin Ian King <colin.king@canonical.com>
Cc: Jeff Dike <jdike@addtoit.com>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>,
linux-um@lists.infradead.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hostfs: fix mismatch between link_file definition and declaration
Date: Mon, 18 Mar 2019 10:30:12 +0100 [thread overview]
Message-ID: <2148931.zAvBH5bg2x@blindfold> (raw)
In-Reply-To: <fa1378b0-3048-8309-a152-8fdf5696731d@canonical.com>
Am Montag, 18. März 2019, 09:41:28 CET schrieb Colin Ian King:
> On 17/03/2019 23:49, Richard Weinberger wrote:
> > Am Montag, 18. März 2019, 00:09:09 CET schrieb Colin King:
> >> From: Colin Ian King <colin.king@canonical.com>
> >>
> >> The function link_file declaration in the header file has the order
> >> of the two arguments (from, to) swapped when compared to the definition
> >> arguments of (to, from). Fix this by swapping them around to match
> >> the definition.
> >>
> >> This error predates the git history, so no idea when this error
> >> was introduced.
> >
> > commit bf4f804738544a95b8bc8d6a7e2629c3fc0240dd
> > Author: jdike <jdike>
> > Date: Sat Dec 9 22:52:44 2000 +0000
> >
> > hostfs now mostly works. Almost all of the common operations are now
> > implemented, the main exceptions being mknod and executing files from
> > a hostfs filesystem.
> >
> > Enough archaeology for today. :-)
>
> Nice. How do you find these ancient git commits?
This commit is from the old UML cvs tree.
I did a import to git some time ago and pushed it to:
https://git.kernel.org/pub/scm/linux/kernel/git/rw/uml-history.git/
For classic pre-git stuff, check:
https://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git/
Thanks,
//richard
next prev parent reply other threads:[~2019-03-18 9:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-17 23:09 [PATCH] hostfs: fix mismatch between link_file definition and declaration Colin King
2019-03-17 23:49 ` Richard Weinberger
2019-03-18 8:41 ` Colin Ian King
2019-03-18 9:30 ` Richard Weinberger [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-03-18 8:46 Walter Harms
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2148931.zAvBH5bg2x@blindfold \
--to=richard@nod.at \
--cc=anton.ivanov@cambridgegreys.com \
--cc=colin.king@canonical.com \
--cc=jdike@addtoit.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox