From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751737AbcGGKLx (ORCPT ); Thu, 7 Jul 2016 06:11:53 -0400 Received: from gloria.sntech.de ([95.129.55.99]:40967 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751113AbcGGKLw (ORCPT ); Thu, 7 Jul 2016 06:11:52 -0400 From: Heiko Stuebner To: Caesar Wang Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, dianders@chromium.org, william.wu@rock-chips.com, huangtao@rock-chips.com, eddie.cai@rock-chips.com, Frank Wang Subject: Re: [PATCH] arm64: dts: rockchip: support the usb2phy for rk3399 evb Date: Thu, 07 Jul 2016 12:11:41 +0200 Message-ID: <2150255.RfISFviJKP@phil> User-Agent: KMail/4.14.10 (Linux/4.3.0-1-amd64; KDE/4.14.14; x86_64; ; ) In-Reply-To: <1467866800-24794-1-git-send-email-wxt@rock-chips.com> References: <1467866800-24794-1-git-send-email-wxt@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Am Donnerstag, 7. Juli 2016, 12:46:40 schrieb Caesar Wang: > From: Frank Wang > > This patch adds the usb2phy needed dts node information for rk3399. > > USB2.0 PHY is comprised of one Host port and one OTG port. > Host Port is for USB2.0 host controller; OTG port is for USB2.0 part of > USB3.0 OTG controller, and as a part to construct a fully feature TypeC > subsystem. > > The USB2.0 vbus gpio is board specific, it's no same with all rk3399 > boards, so move it into evb voard. > > Signed-off-by: Frank Wang > Signed-off-by: Caesar Wang > --- > > arch/arm64/boot/dts/rockchip/rk3399-evb.dts | 4 ++++ > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 19 +++++++++++++++++++ > 2 files changed, 23 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > b/arch/arm64/boot/dts/rockchip/rk3399.dtsi index 4c84229..21d147f 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > @@ -242,6 +242,25 @@ > status = "disabled"; > }; > > + usb2phy: usb2phy { > + compatible = "rockchip,rk3399-usb-phy"; > + rockchip,grf = <&grf>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + usb2phy0: usb2-phy0 { > + #phy-cells = <0>; > + #clock-cells = <0>; > + reg = <0xe458>; > + }; > + > + usb2phy1: usb2-phy1 { > + #phy-cells = <0>; > + #clock-cells = <0>; > + reg = <0xe468>; > + }; > + }; > + The rk3399 uses the innosilicon usb2 phy and the binding we've come up for it looks a lot different than the above. So I'm not sure where this is coming from, especially as I haven't seen the driver part for the rk3399 at all yet. So far Frank was always working on te rk3366 variant, which seemed to be the most complete. Heiko