From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932120AbdERNgV (ORCPT ); Thu, 18 May 2017 09:36:21 -0400 Received: from galahad.ideasonboard.com ([185.26.127.97]:54210 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754943AbdERNgR (ORCPT ); Thu, 18 May 2017 09:36:17 -0400 From: Laurent Pinchart To: Kieran Bingham Cc: linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org, sakari.ailus@iki.fi, niklas.soderlund@ragnatech.se, Kieran Bingham , Greg Kroah-Hartman , Mika Westerberg , Sakari Ailus , "Rafael J. Wysocki" , Dmitry Torokhov , Adam Thomson , John Youn , open list Subject: Re: [PATCH v1 2/3] device property: Add fwnode_graph_get_port_parent Date: Thu, 18 May 2017 16:36:26 +0300 Message-ID: <2150794.GUKVLPLrWM@avalon> User-Agent: KMail/4.14.10 (Linux/4.9.16-gentoo; KDE/4.14.32; x86_64; ; ) In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kieran, Thank you for the patch. On Wednesday 17 May 2017 16:03:38 Kieran Bingham wrote: > From: Kieran Bingham > > V4L2 async notifiers can pass the endpoint fwnode rather than the device > fwnode. I'm not sure I would mention V4L2 in the commit message, as this is generic. > Provide a helper to obtain the parent device fwnode without first > parsing the remote-endpoint as per fwnode_graph_get_remote_port_parent. > > Signed-off-by: Kieran Bingham > --- > drivers/base/property.c | 25 +++++++++++++++++++++++++ > include/linux/property.h | 2 ++ > 2 files changed, 27 insertions(+) > > diff --git a/drivers/base/property.c b/drivers/base/property.c > index 627ebc9b570d..caf4316fe565 100644 > --- a/drivers/base/property.c > +++ b/drivers/base/property.c > @@ -1245,6 +1245,31 @@ fwnode_graph_get_next_endpoint(struct fwnode_handle > *fwnode, EXPORT_SYMBOL_GPL(fwnode_graph_get_next_endpoint); > > /** > + * fwnode_graph_get_port_parent - Return device node of a port endpoint > + * @fwnode: Endpoint firmware node pointing of the port > + * > + * Extracts firmware node of the device the @fwnode belongs to. I'm not too familiar with the fwnode API, but I know it's written in C, where functions don't extract something but return a value :-) How about Return: the firmware node of the device the @endpoint belongs to. > + */ > +struct fwnode_handle * > +fwnode_graph_get_port_parent(struct fwnode_handle *fwnode) This is akin to writing (unsigned int integer) How about calling the variable endpoint ? That would also make the documentation clearer in my opinion, with "the @fwnode belongs to" replaced with "the @endpoint belongs to". > +{ > + struct fwnode_handle *parent = NULL; > + > + if (is_of_node(fwnode)) { > + struct device_node *node; > + > + node = of_graph_get_port_parent(to_of_node(fwnode)); > + if (node) > + parent = &node->fwnode; This part looks good to me, with the above small change, Reviewed-by: Laurent Pinchart > + } else if (is_acpi_node(fwnode)) { > + parent = acpi_node_get_parent(fwnode); I can't comment on this one though. > + } > + > + return parent; > +} > +EXPORT_SYMBOL_GPL(fwnode_graph_get_port_parent); > + > +/** > * fwnode_graph_get_remote_port_parent - Return fwnode of a remote device > * @fwnode: Endpoint firmware node pointing to the remote endpoint > * > diff --git a/include/linux/property.h b/include/linux/property.h > index 2f482616a2f2..624129b86c82 100644 > --- a/include/linux/property.h > +++ b/include/linux/property.h > @@ -274,6 +274,8 @@ void *device_get_mac_address(struct device *dev, char > *addr, int alen); > > struct fwnode_handle *fwnode_graph_get_next_endpoint( > struct fwnode_handle *fwnode, struct fwnode_handle *prev); > +struct fwnode_handle *fwnode_graph_get_port_parent( > + struct fwnode_handle *fwnode); > struct fwnode_handle *fwnode_graph_get_remote_port_parent( > struct fwnode_handle *fwnode); > struct fwnode_handle *fwnode_graph_get_remote_port( -- Regards, Laurent Pinchart