From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751276AbdALIct (ORCPT ); Thu, 12 Jan 2017 03:32:49 -0500 Received: from mout.kundenserver.de ([217.72.192.73]:49812 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750734AbdALIcr (ORCPT ); Thu, 12 Jan 2017 03:32:47 -0500 From: Arnd Bergmann To: Sebastian Reichel Cc: Chen-Yu Tsai , Quentin Schulz , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] power: supply: axp20x_usb_power: fix 64-bit build warning Date: Thu, 12 Jan 2017 09:32:26 +0100 Message-ID: <2151755.ZC9SDDZNPX@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <20170112025824.ifplt45l3syibjda@earth> References: <20170111145211.746189-1-arnd@arndb.de> <20170112025824.ifplt45l3syibjda@earth> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:Y0UJ6v9lTjUCuGbpBtDYZSIR41SuybTk73ZAEJm704Lo/ZL9uz6 Z9g4rHVQc6qm5VUvjOuES7rMRvNQFY7OyC0uQ8IpkWhxq+EywzsXcq9hJ5G8O6SwXj5EYG5 NrdnQGWbD5RbOIY4B8PY85fUD0wsM/IaRaT1RAyrGikpeOIWY5xNApjhjHg/NXPkx2DPfbV 7tUTAIlQp1C1phNOoStIg== X-UI-Out-Filterresults: notjunk:1;V01:K0:HJWpc+NFps4=:I36HyyutM7lGd6W2R7um9Z 216D4zs9RKdyTAV4aEEiQUww9HhUWVZAapfEwuG5G889ovhPxqfnMQJe2Rz3odSVUiinFeNQM wUYQnZ7wbY6UisPMKtQjqncfL0C360FUToDO2REsz4CQggfYGXSODrMAUk9sqPyaC17q2A3hm wsH/fpjx8CHpkxpmkSbsgOAslGfI2Urxf+Vizqc3afdXGgSTawHmrntBhMpbkSGBIXMJuuQdd Q0zelddKsoJ0O8/AlXLUjndrsxU1rqrhlBPT9WXFkshbWsCL1N9tgZy0l2MD5C0T4fINYvE5K 1iu/qG8FDTC/+lXlD7SrLXWqwB7B+npAB7KrIKMx57q6V6wh6F+X4nWO/FhpQNg0IhU0CALGM a9bhRU1yRP/dIECjvopNauIPQ/c3r+AuNDzEku0xjPYdvFtrUYywIsZdywk4oj19jHRd6iQs0 fo/RsAKEqhYIg1LDQ8Mn1aMH0kM4bzR7RHToAqm7qshz12q8Xmkp6U3Ak5+aFC09mBYAY8AlT eXPeZz/wdwIFimgIFfuhX6P/A8/GvG/BUJ6WT1Dx8IXYbTglNA03PbNpaZK3NkEt/Zcq8DoLV yTfECQt5kNvMO/k2pD/SpeTW/DRoMiKfx2Kk54MrMy9DQOvC5/lRsnv7VGZXXCmQ6GPUszuKS P2gZwMyu802fS2paE6D+hBNm6TmRNAKz/l9sPvECqfDgnOVi2I/WgJuh0uBFBjNR7/VQXZbdm kyWqQOHN378cEsQ2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, January 12, 2017 3:58:24 AM CET Sebastian Reichel wrote: > Hi Arnd, > > On Wed, Jan 11, 2017 at 03:51:55PM +0100, Arnd Bergmann wrote: > > Casting a pointer to 'int' is not always valid: > > > > drivers/power/supply/axp20x_usb_power.c: In function 'axp20x_usb_power_probe': > > drivers/power/supply/axp20x_usb_power.c:297:21: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] > > > > This makes the code use uintptr_t explicitly. > > > > Fixes: 0dcc70ca8644 ("power: supply: axp20x_usb_power: use of_device_id data field instead of device_is_compatible") > > Signed-off-by: Arnd Bergmann > > I queued Michal's patch instead: > > https://git.kernel.org/cgit/linux/kernel/git/sre/linux-power-supply.git/commit/?h=for-next&id=15df6d98ec3b40775918fc6ef73d7f1c2d0cf870 Hmm, that doesn't look right: You can't really rely on an 'enum' type to have a specific size, especially not the same size as a pointer, in portable code. IIRC on many architectures it defaults to 'int' rather than 'long', and it might also be 'short' on architectures that default to enums being the smallest integer type that fits. Arnd