public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Keith Owens <kaos@ocs.com.au>
To: Patrick Mochel <mochel@osdl.org>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i386 arch subdivision into machine types for 2.5.8
Date: Wed, 17 Apr 2002 10:55:49 +1000	[thread overview]
Message-ID: <21520.1019004949@kao2.melbourne.sgi.com> (raw)
In-Reply-To: Your message of "Tue, 16 Apr 2002 09:46:09 MST." <Pine.LNX.4.33.0204160911200.848-100000@segfault.osdl.org>

On Tue, 16 Apr 2002 09:46:09 -0700 (PDT), 
Patrick Mochel <mochel@osdl.org> wrote:
>One issue that I encountered along the way was arch/i386/kernel/Makefile. 
>I found that you can't easily build multiple targets in the same 
>directory, and have dependencies for one target in subdirectories. 
>Typically, target objects have one or the other. 
>
>In order to make this work, I had to do:
>
>-all: kernel.o head.o init_task.o
>+all: first_rule kernel.o head.o init_task.o
>
>...
>
>+kernel-subdir-$(CONFIG_PCI)    += pci
>+subdir-y                       := $(kernel-subdir-y)
>+obj-y                          += $(foreach dir,$(subdir-y),$(dir)/$(dir).o)
>
>
>The last part is decent, but the explicit dependency on the first_rule 
>target is kinda gross. Is there a better way to do this? Will kbuild 2.5 
>make this nicer?

Much nicer.

arch/i386/kernel/Makefile.in

link_subdirs(pci ...)
select(head.o init_task.o)

arch/i386/kernel/pci/Makefile.in

select(foo.o bar.o)


  reply	other threads:[~2002-04-17  0:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-04-16 15:55 [PATCH] i386 arch subdivision into machine types for 2.5.8 James Bottomley
2002-04-16 16:46 ` Patrick Mochel
2002-04-17  0:55   ` Keith Owens [this message]
2002-04-16 19:30 ` Eric W. Biederman
2002-04-16 20:51   ` James Bottomley
2002-04-16 21:06     ` Dave Jones
2002-04-16 21:44     ` Eric W. Biederman
2002-04-16 23:27       ` James Bottomley
2002-04-16 23:43         ` H. Peter Anvin
2002-04-17  7:00         ` Eric W. Biederman
2002-04-17 16:31           ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21520.1019004949@kao2.melbourne.sgi.com \
    --to=kaos@ocs.com.au \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mochel@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox