From: "Heiko Stübner" <heiko@sntech.de>
To: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Cc: linux-kernel@vger.kernel.org,
Felipe Balbi <felipe.balbi@linux.intel.com>,
Amelie Delaunay <amelie.delaunay@st.com>,
Minas Harutyunyan <hminas@synopsys.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH v4] usb: dwc2: dwc2_vbus_supply_init: fix error check
Date: Mon, 26 Mar 2018 13:51:05 +0200 [thread overview]
Message-ID: <2158461.zz8sS7CZ86@diego> (raw)
In-Reply-To: <20180326090001.57627-1-tomeu.vizoso@collabora.com>
Am Montag, 26. März 2018, 11:00:01 CEST schrieb Tomeu Vizoso:
> devm_regulator_get_optional returns -ENODEV if the regulator isn't
> there, so if that's the case we have to make sure not to leave -ENODEV
> in the regulator pointer.
>
> Also, make sure we return 0 in that case, but correctly propagate any
> other errors. Also propagate the error from _dwc2_hcd_start.
>
> Fixes: 531ef5ebea96 ("usb: dwc2: add support for host mode external vbus
> supply") Cc: Amelie Delaunay <amelie.delaunay@st.com>
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
next prev parent reply other threads:[~2018-03-26 11:51 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-22 9:39 [PATCH] usb: dwc2: dwc2_vbus_supply_init: fix error check Tomeu Vizoso
2018-03-22 11:39 ` Heiko Stübner
2018-03-22 11:41 ` Heiko Stübner
2018-03-22 12:21 ` Amelie DELAUNAY
2018-03-22 13:06 ` [PATCH v2] " Tomeu Vizoso
2018-03-22 13:14 ` [PATCH v3] " Tomeu Vizoso
2018-03-22 13:26 ` Heiko Stübner
2018-03-22 13:34 ` Tomeu Vizoso
2018-03-24 0:24 ` kbuild test robot
2018-03-26 9:00 ` [PATCH v4] " Tomeu Vizoso
2018-03-26 10:56 ` Amelie DELAUNAY
2018-03-26 11:51 ` Heiko Stübner [this message]
2018-04-04 13:33 ` Tomeu Vizoso
2018-04-05 7:54 ` Minas Harutyunyan
2018-04-05 8:10 ` Tomeu Vizoso
2018-04-05 9:02 ` Grigor Tovmasyan
2018-04-05 8:58 ` Grigor Tovmasyan
2018-04-05 9:51 ` Minas Harutyunyan
2018-04-10 12:28 ` Heiko Stuebner
2018-04-10 13:52 ` Minas Harutyunyan
2018-04-10 15:37 ` Heiko Stübner
2018-04-11 6:50 ` Minas Harutyunyan
2018-04-23 13:24 ` Tomeu Vizoso
2018-04-24 8:58 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2158461.zz8sS7CZ86@diego \
--to=heiko@sntech.de \
--cc=amelie.delaunay@st.com \
--cc=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hminas@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox