From: Evgeniy Polyakov <zbr@ioremap.net>
To: Jiri Kosina <jikos@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
GregKH <greg@kroah.com>
Subject: Re: [PATCH] w1: w1_process() is not freezable kthread
Date: Thu, 05 Nov 2015 16:33:50 +0300 [thread overview]
Message-ID: <215991446730430@web4m.yandex.ru> (raw)
In-Reply-To: <alpine.LNX.2.00.1510281425310.8998@pobox.suse.cz>
Hi
28.10.2015, 08:26, "Jiri Kosina" <jikos@kernel.org>:
> On Tue, 27 Oct 2015, Evgeniy Polyakov wrote:
>
>> > w1_process() calls try_to_freeze(), but the thread doesn't mark itself
>> > freezable through set_freezable(), so the try_to_freeze() call is useless.
>>
>> I believe it is better to mark it freezable, what do you think? Its task
>> is useless if anyone else goes sleeping, it should freeze too.
>
> I fail to see why this kthread should be freezable at all. There is no way
> for w1 device to generate new I/O requests that should be written out to
> filesystem, is it?
w1 doesn't generate such requests, but it was more to make this thread
consistent with majority of other threads in the kernel.
Ok, I'm not against it, Greg please pull this patch into your tree.
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
next prev parent reply other threads:[~2015-11-05 13:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-26 5:53 [PATCH] w1: w1_process() is not freezable kthread Jiri Kosina
2015-10-27 14:30 ` Evgeniy Polyakov
2015-10-28 5:26 ` Jiri Kosina
2015-11-05 13:33 ` Evgeniy Polyakov [this message]
2015-11-19 15:49 ` Jiri Kosina
2015-11-19 16:15 ` GregKH
2016-02-08 5:31 ` GregKH
2016-02-10 10:41 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=215991446730430@web4m.yandex.ru \
--to=zbr@ioremap.net \
--cc=greg@kroah.com \
--cc=jikos@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox