From: David Howells <dhowells@redhat.com>
To: Joerg Roedel <joerg.roedel@amd.com>
Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org,
Ingo Molnar <mingo@elte.hu>, Arnd Bergmann <arnd@arndb.de>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] bitops: Add missing parentheses to new get_order macro
Date: Mon, 05 Mar 2012 15:58:26 +0000 [thread overview]
Message-ID: <21621.1330963106@redhat.com> (raw)
In-Reply-To: <1330088295-28732-1-git-send-email-joerg.roedel@amd.com>
Joerg Roedel <joerg.roedel@amd.com> wrote:
> The new get_order macro introcuded in commit
>
> d66acc39c7cee323733c8503b9de1821a56dff7e
>
> does not use parentheses around all uses of the parameter n.
> This causes new compile warnings, for example in the
> amd_iommu_init.c function:
>
> drivers/iommu/amd_iommu_init.c:561:6: warning: suggest parentheses around comparison in operand of ‘&’ [-Wparentheses]
> drivers/iommu/amd_iommu_init.c:561:6: warning: suggest parentheses around comparison in operand of ‘&’ [-Wparentheses]
>
> Fix those warnings by adding the missing parentheses.
>
> Reported-by: Ingo Molnar <mingo@elte.hu>
> Cc: Ingo Molnar <mingo@elte.hu>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: H. Peter Anvin <hpa@zytor.com>
> Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
Acked-by: David Howells <dhowells@redhat.com>
prev parent reply other threads:[~2012-03-05 15:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-24 12:58 [PATCH] bitops: Add missing parentheses to new get_order macro Joerg Roedel
2012-02-24 15:10 ` Arnd Bergmann
2012-02-24 20:16 ` [tip:x86/asm] " tip-bot for Joerg Roedel
2012-03-05 15:58 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21621.1330963106@redhat.com \
--to=dhowells@redhat.com \
--cc=arnd@arndb.de \
--cc=hpa@zytor.com \
--cc=joerg.roedel@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox