From: Jerome Pouiller <Jerome.Pouiller@silabs.com>
To: "lkp@lists.01.org" <lkp@lists.01.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH] staging: wfx: fix potential vulnerability to spectre
Date: Fri, 11 Oct 2019 12:35:36 +0000 [thread overview]
Message-ID: <2165496.I6CF8xJYvu@pc-42> (raw)
In-Reply-To: <20191011121027.GA1144221@kroah.com>
On Friday 11 October 2019 14:10:35 CEST Greg Kroah-Hartman wrote:
> On Fri, Oct 11, 2019 at 10:15:54AM +0000, Jerome Pouiller wrote:
> > From: Jérôme Pouiller <jerome.pouiller@silabs.com>
> >
> > array_index_nospec() should be applied after a bound check.
> >
> > Fixes: 9bca45f3d6924f19f29c0d019e961af3f41bdc9e ("staging: wfx: allow to send 802.11 frames")
>
> No need for the full sha1, this should be:
> Fixes: 9bca45f3d692 ("staging: wfx: allow to send 802.11 frames")
I copy-pasted information from kbuild robot notification.
I suggest that commit-id in robot notification is also cut down to 12
characters. Or even better, to use this snippet:
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
Fixes: 9bca45f3d692 ("staging: wfx: allow to send 802.11 frames")
(I added lkp@lists.01.org in CC but, I am not sure it is the correct
ML. I am sorry if it is not the case)
--
Jérôme Pouiller
next prev parent reply other threads:[~2019-10-11 12:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 10:15 [PATCH] staging: wfx: fix potential vulnerability to spectre Jerome Pouiller
2019-10-11 12:10 ` Greg Kroah-Hartman
2019-10-11 12:35 ` Jerome Pouiller [this message]
2019-10-11 12:54 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2165496.I6CF8xJYvu@pc-42 \
--to=jerome.pouiller@silabs.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox