Re: [PATCH v1 03/11] dt-bindings: pwm: rockchip: add rockchip,rk3128-pwm

Johan Jonker
2022-09-10T19:48:55Z

Reduced CC.

Hi Rob,

The rk3328 and rv1108 PWM interrupt is chaired between blocks I think.
For rv1108 the same interrupt is used for all PWM nodes.
For rk3328 only added to one PWM node.
Currently not in use in a Linux drivers??

No consensus yet...on removing or parent node, so it stays as it is...
Maybe if you have ideas things will change. ;)

Johan

===

See discussion:
https://lore.kernel.org/linux-rockchip/20b7c702-9412-93b4-3174-e8633bc413d7@gmail.com/

On 9/10/22 16:53, Rob Herring wrote:
> On Sat, 10 Sep 2022 00:02:22 +0200, Johan Jonker wrote:
>> Add rockchip,rk3128-pwm compatible string.
>>
>> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
>> ---
>> Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml | 1 +
>> 1 file changed, 1 insertion(+)
>>
>
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.
>
> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> This will change in the future.
>
> Full log is available here: https://patchwork.ozlabs.org/patch/
>
>
> pwm@10280000: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+'
> arch/arm/boot/dts/rv1108-elgin-r1.dtb
> arch/arm/boot/dts/rv1108-evb.dtb
>
> pwm@10280010: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+'
> arch/arm/boot/dts/rv1108-elgin-r1.dtb
> arch/arm/boot/dts/rv1108-evb.dtb
>
> pwm@10280020: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+'
> arch/arm/boot/dts/rv1108-elgin-r1.dtb
> arch/arm/boot/dts/rv1108-evb.dtb
>
> pwm@10280030: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+'
> arch/arm/boot/dts/rv1108-elgin-r1.dtb
> arch/arm/boot/dts/rv1108-evb.dtb
>
> pwm@20040000: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+'
> arch/arm/boot/dts/rv1108-elgin-r1.dtb
> arch/arm/boot/dts/rv1108-evb.dtb
>
> pwm@20040010: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+'
> arch/arm/boot/dts/rv1108-elgin-r1.dtb
> arch/arm/boot/dts/rv1108-evb.dtb
>
> pwm@20040020: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+'
> arch/arm/boot/dts/rv1108-elgin-r1.dtb
> arch/arm/boot/dts/rv1108-evb.dtb
>
> pwm@20040030: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+'
> arch/arm/boot/dts/rv1108-elgin-r1.dtb
> arch/arm/boot/dts/rv1108-evb.dtb
>
> pwm@ff1b0030: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+'
> arch/arm64/boot/dts/rockchip/rk3318-a95x-z2.dtb
> arch/arm64/boot/dts/rockchip/rk3328-a1.dtb
> arch/arm64/boot/dts/rockchip/rk3328-evb.dtb
> arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dtb
> arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dtb
> arch/arm64/boot/dts/rockchip/rk3328-rock64.dtb
> arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dtb
> arch/arm64/boot/dts/rockchip/rk3328-roc-pc.dtb
>