From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9FCBD1F63DD for ; Mon, 10 Feb 2025 11:58:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739188690; cv=none; b=fQta24vYwntxHVqehzUB0jwLlOAFZqV0KdQi+YgSKjLw2gGwdGN9Wpl88jaOPE1p+08noC0+3MczrK99efYXCavvB4SFKiJTL8cVYHTgmcArzFqRPRo6rZm0tp9PY8BlSluY6XlBaA3yU2H0KJ2pgY8Taj7qWfgwNP6Fbq4FEP8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739188690; c=relaxed/simple; bh=as4SUiBKDJu7f/KIbNhAFDg767Lu1xis1B9Fm+JHYDM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=r4bOry6lMLZ+nQd31DZZwMWmXI+GXxRzyqm3LlJl9eiS5yjjjtm6q949f2JMddiq8kum1SA1QUe7/9PO3NEPxd7k8aFbwp/wSrT63LtL7mUjLsE6HGK7jVW0x7Pkk1R/N2aoZwvOLDl/2Z7d1987HW3amuAqkQLQYGFWh6UkHtM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sigma-star.at; spf=pass smtp.mailfrom=sigma-star.at; dkim=pass (2048-bit key) header.d=sigma-star.at header.i=@sigma-star.at header.b=hF9/qC3q; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sigma-star.at Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sigma-star.at Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sigma-star.at header.i=@sigma-star.at header.b="hF9/qC3q" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4394829ef0fso2868655e9.0 for ; Mon, 10 Feb 2025 03:58:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sigma-star.at; s=google; t=1739188687; x=1739793487; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=as4SUiBKDJu7f/KIbNhAFDg767Lu1xis1B9Fm+JHYDM=; b=hF9/qC3qvEkqii5v99lO+25HlASbdJiZ7L6PoI0wqTQP//BzHFo5utI/Oc/Zul/Rq3 1Y23yhO94yahrt0YarbuS6KA57b41MSq2JME6u7V6AX+P1RrbmgJ7Er/Gw0wzjb9fi0w 15e+iOaPku8YBDmpPMHKaLSUspkLdFmy8qaja+KnU5EGIEXFEScihNfN1gkDQSFwRMSP stfd4NrbWvzctso5rO/eBMoBugLAnlAXx9DF1679nl99G1qfyd/znFsazyD6spd9m7B/ y2HOUmDmqaEZuPiJQEA2/jRHrh/RQLeMM08D39zPL9QfbT2N0iOZsU6Hd2NAvm12fYQ3 SWHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739188687; x=1739793487; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=as4SUiBKDJu7f/KIbNhAFDg767Lu1xis1B9Fm+JHYDM=; b=t9YU3dWqm3k/OdEQ1/CVe4WhupqwY9Kyncrgd7BD/4IuySbc2QpMOqlfWdxZLgPS3L v4tk2sPcX+P3vIowoGtDbF5tYTeioWNzkVgP5uheo9+e8bH/gd9GVr5FubR/suV8nTod ZvksnlkKUjvco0aWSIK+OGqXvfPefAa/spAqFuUj4YCmu8dYJbASjqIRGcg8+LRH14yk ki7LCnxtBNIE80EJB60NJVUz+TljnlwtZFpqg8brT3tNguqwuUbP8pWIxz66pYmCxAyn P8AX1xBFmmP/W3bEdPvMyCTNxtwM7SmrOR15c/VTFMnh3/+Fzv7EAQJjXTjaGDiOKOdp gULw== X-Forwarded-Encrypted: i=1; AJvYcCU3JqJe2tkeqaFR0h0cWszcEhJPGtUJS+JINcsi3nIYT29Pp5ErI74KxHPOuZgJU/QwRAuGHjAMe5QBbV8=@vger.kernel.org X-Gm-Message-State: AOJu0Yz7m3awumhqN4XRmuDUtMVE4oaE7vuGkv9Yst5a4iJoYrNutstB OwKndzL0taxzHB+2X1s/PqcELPtnR0QRkyWsac/WSiHxSfha9uiDNkOftEqP7Iw= X-Gm-Gg: ASbGncunQINtmx5/utgHi8NK16lWexKXnpCLLo/QObXdKuRUBOWg5yJOB0CseARxEMA d8XseDcmMlBCkLUv+EzlrKaKf+U6Kck9zgsniPCQhe3XpyNWCAoNBnZC6hE000xr4Led+yCNz8g mgK/vsGGKqogxQLv2EkwmBYVKgT/f/L0KVW+kti7V0N6dVW9L318E3c1+YutrVKxoIuxyhHO95v 2cQe/qizLV+1V0QT136REDWfB8oScL8PBSulYYRSNYuRS4fRc1BpvvVz/sLA+HbDdfk7xXNPNWI OcEKIyfBemFzJr1N X-Google-Smtp-Source: AGHT+IFEd0xQXpxBXbxhVrVFY+Z1GeZScw7oor+XBNGkufWYSsyj+e3PrFPwPqOelxgNNUVPM0WgUw== X-Received: by 2002:a5d:6da9:0:b0:38d:dffc:c14f with SMTP id ffacd0b85a97d-38ddffcc5ffmr2071887f8f.1.1739188686752; Mon, 10 Feb 2025 03:58:06 -0800 (PST) Received: from somecomputer ([82.150.214.1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38dcc9bd251sm8905203f8f.9.2025.02.10.03.58.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 03:58:06 -0800 (PST) From: Richard Weinberger To: David Gstir , sigma star Kernel Team , James Bottomley , Jarkko Sakkinen , Mimi Zohar , David Howells , Paul Moore , James Morris , "Serge E . Hallyn" , SCE_Linux_Security_team@msteams.nxp.com, upstream@sigma-star.at Cc: linux-integrity@vger.kernel.org, keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Kshitiz Varshney , Kshitiz Varshney Subject: Re: [PATCH v1] trusted_dcp.c: Do not return in case of non-secure mode Date: Mon, 10 Feb 2025 12:58:05 +0100 Message-ID: <2171670.G923GbCHz0@anvil> In-Reply-To: <20250210114606.1593650-1-kshitiz.varshney@nxp.com> References: <20250210114606.1593650-1-kshitiz.varshney@nxp.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On Montag, 10. Februar 2025 12:46 Kshitiz Varshney wrote: > There are multiple type of keys in different worlds, like > test key in case of non-secure world and OTP, unique key > in case of secure world. > So, instead of returning with an error, in case of test key, we > should display warning to the user and allow the user to run the > trusted key functionality with test key. We have the dcp_skip_zk_test module parameter to allow such cases. Why can't you use it? Thanks, //richard =2D-=20 =E2=80=8B=E2=80=8B=E2=80=8B=E2=80=8B=E2=80=8Bsigma star gmbh | Eduard-Bodem= =2DGasse 6, 6020 Innsbruck, AUT UID/VAT Nr: ATU 66964118 | FN: 374287y