* [PATCH] sh-pfc: r8a7790: Fix definition of IPSR5
@ 2014-04-22 15:28 Phil Edworthy
2014-04-22 16:39 ` Laurent Pinchart
2014-04-23 14:09 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Phil Edworthy @ 2014-04-22 15:28 UTC (permalink / raw)
To: Linus Walleij
Cc: Guido Piasenza, Laurent Pinchart, Simon Horman, Linux-SH, LKML,
Phil Edworthy
From: Guido Piasenza <gpiasenza@soft-in.com>
The extra entry in the table makes SCIFA0_B, and all peripherals after it, fail.
Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
---
drivers/pinctrl/sh-pfc/pfc-r8a7790.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7790.c b/drivers/pinctrl/sh-pfc/pfc-r8a7790.c
index 4809371..dbf2ef9 100644
--- a/drivers/pinctrl/sh-pfc/pfc-r8a7790.c
+++ b/drivers/pinctrl/sh-pfc/pfc-r8a7790.c
@@ -4795,7 +4795,7 @@ static const struct pinmux_cfg_reg pinmux_config_regs[] = {
/* IP5_23_21 [3] */
FN_WE1_N, FN_IERX, FN_CAN1_RX, FN_VI1_G4,
FN_VI1_G4_B, FN_VI2_R6, FN_SCIFA0_CTS_N_B,
- FN_IERX_C, 0,
+ FN_IERX_C,
/* IP5_20_18 [3] */
FN_WE0_N, FN_IECLK, FN_CAN_CLK,
FN_VI2_VSYNC_N, FN_SCIFA0_TXD_B, FN_VI2_VSYNC_N_B, 0, 0,
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] sh-pfc: r8a7790: Fix definition of IPSR5
2014-04-22 15:28 [PATCH] sh-pfc: r8a7790: Fix definition of IPSR5 Phil Edworthy
@ 2014-04-22 16:39 ` Laurent Pinchart
2014-04-23 14:09 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Pinchart @ 2014-04-22 16:39 UTC (permalink / raw)
To: Phil Edworthy, Simon Horman; +Cc: Linus Walleij, Guido Piasenza, Linux-SH, LKML
Hi Phil,
Thank you for the patch.
On Tuesday 22 April 2014 16:28:03 Phil Edworthy wrote:
> From: Guido Piasenza <gpiasenza@soft-in.com>
>
> The extra entry in the table makes SCIFA0_B, and all peripherals after it,
> fail.
>
> Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/pinctrl/sh-pfc/pfc-r8a7790.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7790.c
> b/drivers/pinctrl/sh-pfc/pfc-r8a7790.c index 4809371..dbf2ef9 100644
> --- a/drivers/pinctrl/sh-pfc/pfc-r8a7790.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7790.c
> @@ -4795,7 +4795,7 @@ static const struct pinmux_cfg_reg
> pinmux_config_regs[] = { /* IP5_23_21 [3] */
> FN_WE1_N, FN_IERX, FN_CAN1_RX, FN_VI1_G4,
> FN_VI1_G4_B, FN_VI2_R6, FN_SCIFA0_CTS_N_B,
> - FN_IERX_C, 0,
> + FN_IERX_C,
I would have put that last entry at the end of the previous line, to have four
entries on both lines.
> /* IP5_20_18 [3] */
> FN_WE0_N, FN_IECLK, FN_CAN_CLK,
> FN_VI2_VSYNC_N, FN_SCIFA0_TXD_B, FN_VI2_VSYNC_N_B, 0, 0,
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sh-pfc: r8a7790: Fix definition of IPSR5
2014-04-22 15:28 [PATCH] sh-pfc: r8a7790: Fix definition of IPSR5 Phil Edworthy
2014-04-22 16:39 ` Laurent Pinchart
@ 2014-04-23 14:09 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2014-04-23 14:09 UTC (permalink / raw)
To: Phil Edworthy
Cc: Guido Piasenza, Laurent Pinchart, Simon Horman, Linux-SH, LKML
On Tue, Apr 22, 2014 at 5:28 PM, Phil Edworthy
<phil.edworthy@renesas.com> wrote:
> From: Guido Piasenza <gpiasenza@soft-in.com>
>
> The extra entry in the table makes SCIFA0_B, and all peripherals after it, fail.
>
> Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
Patch applied for fixes with Lauren's additional fixup moving the define one
line up.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-04-23 14:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-22 15:28 [PATCH] sh-pfc: r8a7790: Fix definition of IPSR5 Phil Edworthy
2014-04-22 16:39 ` Laurent Pinchart
2014-04-23 14:09 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox