* 2.5.20 config forward references to CONFIG_X86_LOCAL_APIC
@ 2002-06-05 4:55 Keith Owens
2002-06-05 8:07 ` Zwane Mwaikambo
0 siblings, 1 reply; 4+ messages in thread
From: Keith Owens @ 2002-06-05 4:55 UTC (permalink / raw)
To: linux-kernel
arch/i386/config.in tests CONFIG_X86_LOCAL_APIC before it is defined.
dep_bool 'check for P4 thermal throttling interrupt.' CONFIG_X86_MCE_P4THERMAL $CONFIG_X86_MCE $CONFIG_X86_LOCAL_APIC
arch/i386/config.in also includes drivers/acpi/Config.in which tests
CONFIG_X86_LOCAL_APIC before this variable is defined via CONFIG_SMP.
The forward references result in incorrect configurations when
switching config from one cpu type to another or from SMP to UP.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: 2.5.20 config forward references to CONFIG_X86_LOCAL_APIC
2002-06-05 4:55 2.5.20 config forward references to CONFIG_X86_LOCAL_APIC Keith Owens
@ 2002-06-05 8:07 ` Zwane Mwaikambo
2002-06-05 10:14 ` Dave Jones
0 siblings, 1 reply; 4+ messages in thread
From: Zwane Mwaikambo @ 2002-06-05 8:07 UTC (permalink / raw)
To: Keith Owens; +Cc: linux-kernel
Hi Keith,
On Wed, 5 Jun 2002, Keith Owens wrote:
> arch/i386/config.in tests CONFIG_X86_LOCAL_APIC before it is defined.
> dep_bool 'check for P4 thermal throttling interrupt.' CONFIG_X86_MCE_P4THERMAL $CONFIG_X86_MCE $CONFIG_X86_LOCAL_APIC
>
> arch/i386/config.in also includes drivers/acpi/Config.in which tests
> CONFIG_X86_LOCAL_APIC before this variable is defined via CONFIG_SMP.
>
> The forward references result in incorrect configurations when
> switching config from one cpu type to another or from SMP to UP.
We could move the conditional to preprocessor time by wrapping certain
bits in #ifdef (urgh), what really is the more elegant way of doing it?
Regards,
Zwane Mwaikambo
--
http://function.linuxpower.ca
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: 2.5.20 config forward references to CONFIG_X86_LOCAL_APIC
2002-06-05 10:14 ` Dave Jones
@ 2002-06-05 9:56 ` Zwane Mwaikambo
0 siblings, 0 replies; 4+ messages in thread
From: Zwane Mwaikambo @ 2002-06-05 9:56 UTC (permalink / raw)
To: Dave Jones; +Cc: Keith Owens, linux-kernel
On Wed, 5 Jun 2002, Dave Jones wrote:
> On Wed, Jun 05, 2002 at 10:07:15AM +0200, Zwane Mwaikambo wrote:
> > > The forward references result in incorrect configurations when
> > > switching config from one cpu type to another or from SMP to UP.
> > We could move the conditional to preprocessor time by wrapping certain
> > bits in #ifdef (urgh), what really is the more elegant way of doing it?
>
> Doing the CONFIG_X86_LOCAL_APIC definition earlier.
... so simple it hurts ...
--
http://function.linuxpower.ca
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: 2.5.20 config forward references to CONFIG_X86_LOCAL_APIC
2002-06-05 8:07 ` Zwane Mwaikambo
@ 2002-06-05 10:14 ` Dave Jones
2002-06-05 9:56 ` Zwane Mwaikambo
0 siblings, 1 reply; 4+ messages in thread
From: Dave Jones @ 2002-06-05 10:14 UTC (permalink / raw)
To: Zwane Mwaikambo; +Cc: Keith Owens, linux-kernel
On Wed, Jun 05, 2002 at 10:07:15AM +0200, Zwane Mwaikambo wrote:
> > The forward references result in incorrect configurations when
> > switching config from one cpu type to another or from SMP to UP.
> We could move the conditional to preprocessor time by wrapping certain
> bits in #ifdef (urgh), what really is the more elegant way of doing it?
Doing the CONFIG_X86_LOCAL_APIC definition earlier.
Dave.
--
| Dave Jones. http://www.codemonkey.org.uk
| SuSE Labs
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2002-06-05 10:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-06-05 4:55 2.5.20 config forward references to CONFIG_X86_LOCAL_APIC Keith Owens
2002-06-05 8:07 ` Zwane Mwaikambo
2002-06-05 10:14 ` Dave Jones
2002-06-05 9:56 ` Zwane Mwaikambo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox