Re: [PATCH 4/7] FS-Cache: Export find_get_pages()

Andrew Morton
2006-04-21T00:17:03Z

David Howells <dhowells@redhat.com> wrote:
>
> Christoph Hellwig <hch@infradead.org> wrote:
>
> > > The attached patch exports find_get_pages() for use by the kAFS filesystem
> > > in conjunction with it caching patch.
> >
> > Why don't you use pagevec ?
>
> You mean pagevec_lookup() I suppose... That's probably reasonable, though
> slower.
>

But the code's using pagevecs now. In a strange manner.

+ nr_pages = find_get_pages(vnode->vfs_inode.i_mapping, first,
+ PAGEVEC_SIZE, pvec.pages);

that's an open-coded pagevec_lookup().