Re: [PATCH 3/7] FS-Cache: Avoid ENFILE checking for kernel-specific open files

Andrew Morton
2006-04-21T18:23:58Z

David Howells <dhowells@redhat.com> wrote:
>
> > > +struct file *get_empty_filp(int kernel)
> >
> > I'd suggest a new get_empty_kernel_filp(void) rather than providing a magic
> > argument. (we can still have the magic argument in the new
> > __get_empty_filp(int), but it shouldn't be part of the caller-visible API).
> > ...
> > It would be more flexible to make the caller pass in the flags directly.
>
> So:
>
> struct file *get_empty_kernel_filp(unsigned short flags);
>
> which devolves to get_empty_filp() if flags == 0?
>

argh, I forgot about the flag. Oh well. I'd suggest:

static inline struct file *get_empty_filp(void)
{
return __get_empty_filp(0);
}

static inline struct file *get_empty_kernel_filp(void)
{
return __get_empty_filp(0);
}