Re: [PATCH 1/7] FS-Cache: Provide a filesystem-specific sync'able page bit

Andrew Morton
2006-04-21T10:34:40Z

David Howells <dhowells@redhat.com> wrote:
>
> Andrew Morton <akpm@osdl.org> wrote:
>
> > It would be better to rename PG_checked to PG_fs_misc kernel-wide.
>
> So would deleting PG_checked and changing the PageChecked() macros to:
>
> #define PageChecked(page) PageFsMisc((page))
> #define SetPageChecked(page) SetPageFsMisc((page))
> #define ClearPageChecked(page) ClearPageFsMisc((page))
>
> be acceptable? Or would you rather I replaced those too?
>

PG_checked is presently a misc bit which only filesystems use. So yes, I'd
say it's appropriate to remove PageChecked() and friends altogether.

That might break out-of-tree filesystems, but they'll work it out.