From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754886AbcIMHhH (ORCPT <rfc822;w@1wt.eu>);
        Tue, 13 Sep 2016 03:37:07 -0400
Received: from mout.kundenserver.de ([212.227.17.24]:56295 "EHLO
        mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751091AbcIMHhE (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 13 Sep 2016 03:37:04 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Peter Chen <hzpeterchen@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Peter Chen <peter.chen@nxp.com>, Felipe Balbi <balbi@kernel.org>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: Kconfig: make USB_ULPI_BUS select USB_COMMON
Date: Tue, 13 Sep 2016 09:36:39 +0200
Message-ID: <21754633.f6gFxZW7VA@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <20160913071942.GC30425@b29397-desktop>
References: <20160912153649.3163096-1-arnd@arndb.de> <2868310.g9cFv2gbYX@wuerfel> <20160913071942.GC30425@b29397-desktop>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:/CsdqUFPCSJkEb8EbZSXk0NBbF6rU/FmkT+6sA1tzmENdRBIjVO
 Gmk2roYYH1DZOr7DRhRknh566awBbFJrSirO+FLDL3wO2wgi5i1LSsZ6JY7wkHChGsO3LIQ
 NUQt/AsvBSJ0jZMp1MdquI459EvqWlfzri9Rz6Y47IVUotLyBI4Pdg3FtKEA9P5LSaGL1z3
 ILRcAijPtC0jrjEV+qbCw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:c9hXD7KWHkQ=:jmK4rDigGZvSEY4vM5p0R3
 EAu+ckm1pN8waBxmwyyj18tTvGw8eI1gfWkaOVJIvyf5+gNLDscgOWJkZtpn8SVPvBUHQSbx6
 LPeiaQE7a2QLLxtpO6jGds99O9+E1I5n5Ofv0+x5TnTuBAvc6FaUwEZ6jf9hJshTkE462Uemv
 JgLO7EhmKGrUWIHNGMYIIr1N+5sWJPxaNgZZBfy+liTzF7Wfg+YeIh8S4u9kp2qPyHlj9ndFf
 z7kXuY/UDWm05IjMUS/emr/KIHMIPPhK/KiqjuDsvtkzEQbQX3ey1HT/32dQsv4lu/eckY5KK
 YpBLJ/cKKQC5kwhswDlXs2wL0s/DgojKO347Jpnp08RXha48KaoSGS52/PFjsL9Fzv52uLQYk
 P+RLVvakSfVM1IJMAxBDrSt7Wpr0ouvb+ajj6eDQQY8xEHQfxd5eioDHj8XcLaTaphPuQaDJB
 2kucM+FYmZFofAP+gW8xrW6U/WJCl5gqGNXTY7TCAIDd5xy4Ydd3ieadlP3cxVhKfMuSsp9Le
 gn3s0pvF3jLrm8UoB4eM8bSwacx7MgRVATNEfVo1xriREWtOMbe69V+94jFWeUJakltUmWCXO
 9Yo92st5I99y0MSEgkZktEMKKhV2Jlh8CCIglvoIkeUDXNf4oZbPKEDCtX4Z0fb4azCFY6zyv
 dxeXYwMwIMwS6ESgs8DC7ZC4MOZl2l3hujrhogDkxkI6u8d/IwNsbE3LxdisS6uIzT9gLSO4G
 PgoAEZfDr/0QqbdO
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday, September 13, 2016 3:19:42 PM CEST Peter Chen wrote:
> 
> I just see below Kconfig entry at the same Kconfig
> (drivers/usb/Kconfig), and forget your changes.
> 
> config USB_LED_TRIG
>         bool "USB LED Triggers"
>         depends on LEDS_CLASS && USB_COMMON && LEDS_TRIGGERS
>         help
>           This option adds LED triggers for USB host and/or gadget activity.
> 
>           Say Y here if you are working on a system with led-class supported
>           LEDs and you want to use them as activity indicators for USB host or
>           gadget.
> 
> Just grep it, some Kconfig still uses depends on for USB_COMMON, let me
> change it together.
> 

I suspect this one above should instead depend on "USB_SUPPORT".

	Arnd