public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sean Anderson <sean.anderson@linux.dev>
To: Tudor Ambarus <tudor.ambarus@linaro.org>,
	Pratyush Yadav <pratyush@kernel.org>,
	Michael Walle <mwalle@kernel.org>,
	linux-mtd@lists.infradead.org
Cc: Richard Weinberger <richard@nod.at>,
	linux-kernel@vger.kernel.org,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH] mtd: spi-nor: Enable locking for n25q00a
Date: Mon, 6 Oct 2025 18:38:27 -0400	[thread overview]
Message-ID: <21760ebf-99f8-4ea3-8841-e023e00ae574@linux.dev> (raw)
In-Reply-To: <20251006223409.3475001-1-sean.anderson@linux.dev>

On 10/6/25 18:34, Sean Anderson wrote:
> The datasheet for n25q00a shows that the status register has the same
> layout as for n25q00, so use the same flags to enable locking support.
> These flags should have been added back in commit 150ccc181588 ("mtd:
> spi-nor: Enable locking for n25q128a11"), but they were removed by the

Sorry, this should be commit f80ff13135cb ("mtd: spi-nor: micron-st: Enable locking for n25q00")

https://lore.kernel.org/all/20200421063313.32655-1-js07.lee@samsung.com/

> maintainer...
> 
> Signed-off-by: Sean Anderson <sean.anderson@linux.dev>
> ---
> Tested with a mt25qu01gbbb, which shares the same flash ID.
> 
>  drivers/mtd/spi-nor/micron-st.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/mtd/spi-nor/micron-st.c b/drivers/mtd/spi-nor/micron-st.c
> index 187239ccd549..17c7d6322508 100644
> --- a/drivers/mtd/spi-nor/micron-st.c
> +++ b/drivers/mtd/spi-nor/micron-st.c
> @@ -486,6 +486,8 @@ static const struct flash_info st_nor_parts[] = {
>  		.id = SNOR_ID(0x20, 0xbb, 0x21),
>  		.name = "n25q00a",
>  		.size = SZ_128M,
> +		.flags = SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB | SPI_NOR_4BIT_BP |
> +			 SPI_NOR_BP3_SR_BIT6,
>  		.no_sfdp_flags = SECT_4K | SPI_NOR_QUAD_READ,
>  		.mfr_flags = USE_FSR,
>  		.fixups = &n25q00_fixups,


  reply	other threads:[~2025-10-06 22:38 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-06 22:34 [PATCH] mtd: spi-nor: Enable locking for n25q00a Sean Anderson
2025-10-06 22:38 ` Sean Anderson [this message]
2025-10-08  5:05   ` Tudor Ambarus
2025-10-08 12:38     ` Pratyush Yadav
2025-10-07 13:15 ` Pratyush Yadav
2025-10-07 14:20   ` Sean Anderson
2025-10-08 12:30     ` Pratyush Yadav
2025-10-08 12:40       ` Pratyush Yadav
2025-10-09 22:27       ` Sean Anderson
2025-10-09 23:07         ` Pratyush Yadav
2025-10-10 15:45           ` Sean Anderson
2025-10-13  7:30             ` Tudor Ambarus
2025-10-14 18:25               ` Sean Anderson
2025-11-10  7:08                 ` Tudor Ambarus
2025-11-10 10:16                   ` Pratyush Yadav
2025-11-10 16:36                   ` Sean Anderson
2025-11-11  6:07                     ` Tudor Ambarus
2025-11-12 13:10                 ` Miquel Raynal
2025-11-12 13:20                   ` Miquel Raynal
2025-11-12 13:34                     ` Michael Walle
2025-11-13 15:32                   ` Sean Anderson
2025-11-14 17:55                     ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21760ebf-99f8-4ea3-8841-e023e00ae574@linux.dev \
    --to=sean.anderson@linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=mwalle@kernel.org \
    --cc=pratyush@kernel.org \
    --cc=richard@nod.at \
    --cc=tudor.ambarus@linaro.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox