From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D77A7C43610 for ; Thu, 29 Nov 2018 14:07:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A94DA2133F for ; Thu, 29 Nov 2018 14:07:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A94DA2133F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728926AbeK3BMr (ORCPT ); Thu, 29 Nov 2018 20:12:47 -0500 Received: from gloria.sntech.de ([185.11.138.130]:53116 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728857AbeK3BMq (ORCPT ); Thu, 29 Nov 2018 20:12:46 -0500 Received: from ip5f5a905a.dynamic.kabel-deutschland.de ([95.90.144.90] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.0:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gSMyK-0003fP-3z; Thu, 29 Nov 2018 15:07:16 +0100 From: Heiko Stuebner To: sre@kernel.org Cc: robh+dt@kernel.org, mark.rutland@arm.com, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, mdf@kernel.org Subject: Re: [PATCH v2] power: supply: bq24190_charger: add support for bq24196 variant Date: Thu, 29 Nov 2018 15:07:15 +0100 Message-ID: <2186433.S1hFpfxTzA@phil> In-Reply-To: <20181113124753.29948-1-heiko@sntech.de> References: <20181113124753.29948-1-heiko@sntech.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sebastian, Am Dienstag, 13. November 2018, 13:47:53 CET schrieb Heiko Stuebner: > From: Heiko Stuebner > > The bq24196 is another variant of the bq24190 charger ic. > Its register set is identical to the bq24192 and it even reuses > the same part number (0x5). > > Signed-off-by: Heiko Stuebner any opinion on the underlying bq24192 and this bq24196 support? It's a month now for Brian's patches and 2 weeks for my small bq24196 addition, so it would be cool to know if there needs to be done more to get it included. Thanks Heiko > --- > This should go on top of the bq24192 support patches from Brian Masney / > Jonathan Marek [0] > > [0] https://patchwork.kernel.org/patch/10663409/ > > changes in v2: > - add missing compatible to dt-binding > > Documentation/devicetree/bindings/power/supply/bq24190.txt | 1 + > drivers/power/supply/bq24190_charger.c | 4 +++- > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/power/supply/bq24190.txt b/Documentation/devicetree/bindings/power/supply/bq24190.txt > index c8ac028bd3c7..ffe2be408bb6 100644 > --- a/Documentation/devicetree/bindings/power/supply/bq24190.txt > +++ b/Documentation/devicetree/bindings/power/supply/bq24190.txt > @@ -5,6 +5,7 @@ Required properties: > * "ti,bq24190" > * "ti,bq24192" > * "ti,bq24192i" > + * "ti,bq24196" > - reg: integer, I2C address of the charger. > - interrupts[-extended]: configuration for charger INT pin. > > diff --git a/drivers/power/supply/bq24190_charger.c b/drivers/power/supply/bq24190_charger.c > index 4e64e6ac95c5..effa7c3c21e6 100644 > --- a/drivers/power/supply/bq24190_charger.c > +++ b/drivers/power/supply/bq24190_charger.c > @@ -143,7 +143,7 @@ > #define BQ24190_REG_VPRS_PN_MASK (BIT(5) | BIT(4) | BIT(3)) > #define BQ24190_REG_VPRS_PN_SHIFT 3 > #define BQ24190_REG_VPRS_PN_24190 0x4 > -#define BQ24190_REG_VPRS_PN_24192 0x5 /* Also 24193 */ > +#define BQ24190_REG_VPRS_PN_24192 0x5 /* Also 24193, 24196 */ > #define BQ24190_REG_VPRS_PN_24192I 0x3 > #define BQ24190_REG_VPRS_TS_PROFILE_MASK BIT(2) > #define BQ24190_REG_VPRS_TS_PROFILE_SHIFT 2 > @@ -1973,6 +1973,7 @@ static const struct i2c_device_id bq24190_i2c_ids[] = { > { "bq24190" }, > { "bq24192" }, > { "bq24192i" }, > + { "bq24196" }, > { }, > }; > MODULE_DEVICE_TABLE(i2c, bq24190_i2c_ids); > @@ -1982,6 +1983,7 @@ static const struct of_device_id bq24190_of_match[] = { > { .compatible = "ti,bq24190", }, > { .compatible = "ti,bq24192", }, > { .compatible = "ti,bq24192i", }, > + { .compatible = "ti,bq24196", }, > { }, > }; > MODULE_DEVICE_TABLE(of, bq24190_of_match); >