From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: corentin.chary@gmail.com, luke@ljones.dev,
Hans de Goede <hdegoede@redhat.com>,
platform-driver-x86@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] platform/x86: asus-wmi: Consider device is absent when the read is ~0
Date: Fri, 8 Mar 2024 10:56:30 +0200 (EET) [thread overview]
Message-ID: <2186f344-a3dc-33f2-388a-55f91f31f775@linux.intel.com> (raw)
In-Reply-To: <20240308053255.224496-1-kai.heng.feng@canonical.com>
[-- Attachment #1: Type: text/plain, Size: 583 bytes --]
On Fri, 8 Mar 2024, Kai-Heng Feng wrote:
> AAEON PICO-TGU4 board doesn't have any LED but there are bogus LED
> controls under /sys/class/leds:
> $ ls /sys/class/leds
> asus::kbd_backlight asus::lightbar platform::micmute
>
> The reason is that the ~0 read from asus_wmi_get_devstate() is treated
> as a valid state, in truth it means the device is absent.
>
> So filter out ~0 read to prevent bogus LED controls being created.
>
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
--
i.
next prev parent reply other threads:[~2024-03-08 8:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 5:32 [PATCH] platform/x86: asus-wmi: Consider device is absent when the read is ~0 Kai-Heng Feng
2024-03-08 8:56 ` Ilpo Järvinen [this message]
2024-03-11 12:00 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2186f344-a3dc-33f2-388a-55f91f31f775@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=corentin.chary@gmail.com \
--cc=hdegoede@redhat.com \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox