Re: [PATCH 0/2] MN10300: Add the MN10300 architecture to Linux kernel [try #3]

[David Howells <dhowells@redhat.com>]

Adrian Bunk <bunk@kernel.org> wrote:

> The patch to include/asm-generic/Kbuild.asm doesn't seem to be required.

It is.  asm/a.out.h does not exist for MN10300, therefore the export process
breaks unless it is told not to export this header.  The alternative is to
move this line into each arch's individual header Kbuild file.

Whatever, I've moved this to the AOUT suppression patch as that's where it
logically belongs.

> +#elif defined(__mn10300__)
> 
> Please use a CONFIG_ variable in such cases.

Done.  However, I suspect these should be moved into an arch header file
somewhere.

> The parts outside arch/mn10300/ and include/asm-mn10300/ (except for the 
> trivial "&& {,!}MN10300" Kconfig changes) should go separately through 
> the maintainers or get ACKs from the maintainers, even more since they 
> also contain cleanups like
> 
> -               .regions = {ERASEINFO(0x01000,64),
> +               .regions        = {
> +                       ERASEINFO(0x01000,64),
>                 }

I've ditched the extraneous cleanups.  The jedec file needs a lot of cleanup
work anyway as it's got a lot of lines that begin with a space and a tab, but
that's outside of the scope of these patches.

I've split the addition of the jedec chip type, the fix for the net2280 driver
and the allocation of UART port types into separate patches.  These can go in
advance of the main patch.

I've split the remaining MTD changes into their own patch that goes after the
main patch.

> +extern void __kprobes arch_remove_kprobe(struct kprobe *p);

I've moved that into asm-mn10300/kprobes.h.

> > A suitable toolchain can be downloaded from:
> > 
> > 	ftp://ftp.redhat.com/pub/redhat/gnupro/AM33/
> >...
> 
> What is the status of support in upstream GNU binutils and GNU gcc?

Upstream and been there for years I believe.

David