From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754721AbbLJP6c (ORCPT ); Thu, 10 Dec 2015 10:58:32 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:37351 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751661AbbLJP63 (ORCPT ); Thu, 10 Dec 2015 10:58:29 -0500 X-AuditID: cbfee61a-f79266d000003652-fd-5669a1225ced From: Bartlomiej Zolnierkiewicz To: Krzysztof Kozlowski Cc: Thomas Abraham , Sylwester Nawrocki , Mike Turquette , Kukjin Kim , Kukjin Kim , Viresh Kumar , Ben Gamari , Tomasz Figa , Lukasz Majewski , Heiko Stuebner , Chanwoo Choi , Kevin Hilman , Javier Martinez Canillas , Tobias Jakobi , Anand Moon , linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 7/8] ARM: dts: Exynos5422: fix OPP tables Date: Thu, 10 Dec 2015 16:57:22 +0100 Message-id: <2192451.zF6EhNeeQc@amdc1976> User-Agent: KMail/4.13.3 (Linux/3.13.0-63-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <56669126.7050803@samsung.com> References: <1449512300-17230-1-git-send-email-b.zolnierkie@samsung.com> <1449512300-17230-8-git-send-email-b.zolnierkie@samsung.com> <56669126.7050803@samsung.com> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrCIsWRmVeSWpSXmKPExsVy+t9jAV2lhZlhBg/2alvMmn+XxeL6l+es Fv8fvWa1ePN2DZPF6xeGFr0LrrJZ9D9+zWzx9fAKRos3DzczWmx6fI3V4vKuOWwWn3uPMFrM OL+PyWLdxlvsFk8nXGSzOPymndWiYxmjRdvqD6wWq3b9YbTY+NXDQcRj56y77B6bVnWyedy5 tofNY/OSeo9/x9g9tvQDhfu2rGL0OPPb2WP7tXnMHp83yQVwRXHZpKTmZJalFunbJXBlNB39 yljwm7fi1Lvl7A2ME7m7GDk5JARMJK4e72KBsMUkLtxbz9bFyMUhJLCUUeLoz3YmCOcro0TD /8uMIFVsAlYSE9tXgdkiAoYSB3dvBytiFnjCKtG1cw/YKGEBB4mNO7aB2SwCqhKL7vewdjFy cPAKaEpceywLEhYV8JJ4/3MuM4jNKaAtsa2/kxli2QpGiY87zrOBJHgFBCV+TL4HNodZQF5i 3/6prBC2lsT6nceZJjAKzEJSNgtJ2SwkZQsYmVcxSqQWJBcUJ6XnGuallusVJ+YWl+al6yXn 525iBMflM6kdjAd3uR9iFOBgVOLhfSGdGSbEmlhWXJl7iFGCg1lJhHfLDKAQb0piZVVqUX58 UWlOavEhRmkOFiVx3tpLkWFCAumJJanZqakFqUUwWSYOTqkGxqu63Fo7cuI/BfDfbEqobTLf zv1c/FrsXvfQtELFg/1XfDfNeplVGKXgKfY9rOqgvYvXLY2axaFBtZ7G+z4GpnR1Fv91Yt+x n3cbZ92efE7mGv7mtJNFDL9quLdcXXvj7o3sKw8XM5TMKnB58LGB5UvaieOTT/25XbZmcv6s y09OiW3zndasqsRSnJFoqMVcVJwIAHtcolLHAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tuesday, December 08, 2015 05:13:26 PM Krzysztof Kozlowski wrote: > On 08.12.2015 03:18, Bartlomiej Zolnierkiewicz wrote: > > From: Ben Gamari > > > > The Exynos 5422 is identical to the 5800 except for the fact that it > > boots from the A7 cores. Consequently, the core numbering is different: > > cores 0-3 are A7s whereas 4-7 are A15s. > > > > We can reuse the device tree of the 5800 for the 5422 but we must take > > care to override the OPP tables and CPU clocks. These are otherwise > > inherited from the exynos5800 devicetree, which has the CPU clusters > > reversed compared to the 5422. This results in the A15 cores only > > reaching 1.4GHz, the maximum rate of the KFC clock. > > > > Cc: Javier Martinez Canillas > > Signed-off-by: Ben Gamari > > Signed-off-by: Bartlomiej Zolnierkiewicz > > --- > > arch/arm/boot/dts/exynos5422-cpus.dtsi | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > This looks like a very-non-atomic way of handling a change. You added > opp tables to exynos5420 before so at that time they will be applied to > Odroid XU3 family which uses different CPU order. After that you are > fixing the tables to proper CPU order. Direct bisectability probably > won't be an issue because all of DTS would go to separate branch... but > the logic behind confuses. It was done this way to preserve original authorship of changes and bisectability should not be affected unless patch #8 is merged before patch #7. > I think this should be squashed into 3/8. OK. > Best regards, > Krzysztof Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics