From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56CFB1C84A0 for ; Fri, 19 Dec 2025 13:51:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766152271; cv=none; b=ICmaVWjTrx9IDv/A5jTbFruMGGA/C5SqYKKrNq8xrgS11h22D6x/FWfmWv9ZmWM/dC5N3dEArf5/ctLTCUNZzkCEpG5ta/WA8UaxBAGYJeVJT/0jGshl0murPy5b0KDrHQxDSs/SvD9dgwjEgYerqIUhfSb0lt4rhLpxy61Q/KM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766152271; c=relaxed/simple; bh=zifKS0279SxPrQ+mfSbCon2mTPfxEvbsenFlUY4BnAQ=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=jzZ0tSXBGPFy+jkeyrePb66Ypgb1rhnmusJRvhiH+xIdfndfCm9EJCiS4pOlPlRwhqyebc3y0zFLbKvGcYDap34kl7QhKVs03MSLrOB2b2LkeS9boQW7pMisVTYjIjabcDrjrGu3q30pRq4M5GLdyM1wjLtzO1ZIOJleBnNUllo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XY2orDqC; arc=none smtp.client-ip=209.85.208.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XY2orDqC" Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-640e9f5951aso4203945a12.1 for ; Fri, 19 Dec 2025 05:51:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766152266; x=1766757066; darn=vger.kernel.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=WVY0FTbz4AdN3t8EEt7ziV7biZCYpab1ixrilZdONsw=; b=XY2orDqCNlkpYUoAO9/h9/7Q8WLKmUBpnsitimeHE1cDSUfclcY6s7IHYrIMUN9n2i WDyMqShq5hJ639C4QZYp7tIu6RMXeThs/xHdUM3VwYZ/Vr7BNv1AInUZ41ZGl+X8tzwl xofZ2Xim6vaEuvgCKjiByj9EVxDiKQ/lqV0EAEtUoTdonN6bgDIiuPJgb6LYNOVcl93s bsD3DdZtW/ioUsB+KowCCixigeUrb0AaB4CQMOhvKADmRJhn0Zp79j7wcf/JsOv3gqgY VZazDhn8ernXvKku2O4qbSZeuMGsx/5q/KUiXb8ea26vDruk/X5xgvgMXJCfG9b+IESq 6+wQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766152266; x=1766757066; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=WVY0FTbz4AdN3t8EEt7ziV7biZCYpab1ixrilZdONsw=; b=Q/Eiw9laLgoYQV7vDrukmysArdnlZhtuHkE/LkMGNp/0SBxlIH+h4/T6BYxvS2ZXd9 Ojb215raVrU090s0/omHXvjYPk5clhgnMNjd+J45XttsB284sSKpZl4GWkzd0ZPmnjwx pSU8z5GC7v3EXeBRbPYID4Xk7Q1T1KsKfqWrSx57zYJIcOrCU6/v6qaK7/SR8hTry6vX nT/5wx5WCynr53ghhKMafWTjW6PLZs4Kpzv/qlACPWAnhbeQaVmtM3Rcu79T2KTKmXdP wQAkyuzE242HahM5VqKkRJuUIuBXlQTvl5AgqC4qrr0Hijz703tF/VbbvQW520XBFqpG W6Zw== X-Gm-Message-State: AOJu0YzbFCD+M/sXQgDmVprA5hY7+Sxelh8f755XgRRYESsbFvJXX7AG 9BGQE0ZepXNhIoYaHILxfMMcEQedKX6jPJ6uOOQtQBHsl5SEK+m66Kk1 X-Gm-Gg: AY/fxX4L1DIohRW+pcg146+/DRw4p+WxpFfdFEgwyCFtuYeg0y83n9ZzfeYZrByIBln Oici5lJnLA8Y9Vs98xnlcO/AUujlAQ6jeSiauugztkjZbGYTDb8YA8TBLwFwA5IPRyAl2OpA73Z vrczgathM2cGjI50ELHeBT0H8RVKPZ5563WZidTc22xCWsPU+jWVc8Trxj9zyCG/84T8dVHWH+S WrVeHdCSTrg4Nat1SW1aQRvO7KSMqDwP+x9xYBOCM7V9/oCMUzWb6Cwt/Ei+Xd/eBZ6FgFXYvtx TzrqtlincMTzC7HtitLoxE7V2odK9Y8WWWHfLH6UvYV+q7SxjMwZt+Yo49c6keAaHHMkxxdJIF+ AD0SOOMTFUO7jbjsM4O4NnGUrxDfyHz3J8xnCba7R4spQHA+KRtjEbRsU5oBToPfhfTJjS3cSKD 6nQNhYAXvSjz9/zhj7Y13qP2nr/2E59WsuR6Wmw7PmYgI2oATBw52VTMXeD/oA78Rp X-Google-Smtp-Source: AGHT+IHqGj9nyeirOfNEOBoQJdeIZKX2jxqMX1La5bEetWOpLjaUzix23G3qWZHuR52h5YIkt2/e2A== X-Received: by 2002:a17:907:96a2:b0:b76:afa4:933f with SMTP id a640c23a62f3a-b80205de9dcmr597496066b.22.1766152266241; Fri, 19 Dec 2025 05:51:06 -0800 (PST) Received: from smtpclient.apple (89-66-237-154.dynamic.play.pl. [89.66.237.154]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037ae2dbesm244601566b.29.2025.12.19.05.51.04 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 Dec 2025 05:51:05 -0800 (PST) Content-Type: text/plain; charset=utf-8 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\)) Subject: Re: [PATCH v7 00/17] media: rkvdec: Add support for VDPU381 and VDPU383 From: Piotr Oniszczuk In-Reply-To: <20251218232829.337811-1-detlev.casanova@collabora.com> Date: Fri, 19 Dec 2025 14:50:51 +0100 Cc: linux-kernel@vger.kernel.org, Mauro Carvalho Chehab , Ezequiel Garcia , Heiko Stuebner , Daniel Almeida , Jonathan Corbet , Ricardo Ribalda , Hans Verkuil , Yunke Cao , Hans de Goede , Laurent Pinchart , Nicolas Dufresne , Pavan Bobba , Sakari Ailus , James Cowgill , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, kernel@collabora.com, Jonas Karlman Content-Transfer-Encoding: quoted-printable Message-Id: <219DE002-BE77-4D28-9BC6-9124F099F211@gmail.com> References: <20251218232829.337811-1-detlev.casanova@collabora.com> To: Detlev Casanova X-Mailer: Apple Mail (2.3826.700.81) > Wiadomo=C5=9B=C4=87 napisana przez Detlev Casanova = w dniu 19 gru 2025, o godz. 00:28: >=20 > These variants are found respectively in the RK3588 and RK3576 SoCs. > This patch only adds support for H264 and H265 in both variants. >=20 > As there is a considerable part of the code that can be shared with = the > already supported rkvdec decoder driver, the support for these = variants > is added here rather than writing a new driver. >=20 > This patch set uses the newly introduced hevc_ext_sps_[ls]t_rps v4l2 > controls for HEVC. > Therefore, a patched version of userpace tools is needed for HEVC > support (added for GStreamer[1] and in an early stage for FFmpeg[2]). >=20 > The DTS changes can be found in another patch set: [3] >=20 > [1]: = https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/9355 > [2]: https://gitlab.collabora.com/detlev/ffmpeg > [3]: = https://lore.kernel.org/all/20251020212009.8852-1-detlev.casanova@collabor= a.com/ >=20 Detlev, FYI: In my testbed with=20 i. v7 of [1] on mainline 6.18.2 ii ffmpeg8 v4l2_request [2] iii. mythv as player [3] iv. minimyth2 as distro [4] v. NO applied yours ffmpeg sps/rps hinting [5] (as i'm on ffmpeg8) I run set of my mpeg2/h264/hevc/vp8/vp9 samples on: rk3328. rk3399, = rk3566, rk3576, rk3588 and h616 (just for brief test for potential = cross-regressions) Results: a. rk3328: no any regressions; all samples are decoded ok b. rk3399: no any regressions; all samples are decoded ok c. rk3566: no any regressions (e.g. in vp9. v6 and older were = regressing; v7 is ok) =20 c.1 h264: all ok c.2 hevc: samples without long-term sps/rps: all ok. c.3 hevc: samples with long-tern sps/rps: v7 is a bit regressing here: = it gives me sometimes kernel oops requiring hw. reset to bring decoder = back to live.=20 Exemplary oops: https://termbin.com/upju Older vers of your code were handling such cases without needs of hw. = reset d. rk3576: d.1: h264: works ok - but randomly i'm getting playback with distortions = like this: https://postimg.cc/Yh8Djc3L. it is avd. 1 per few playbacks. d.2: hevc: the same like c.1 and c.2 e. rk3588 e.1: h264: all ok e.2: hevc: the same like c.1 and c.2 =20 g. h616 with cedrus: all ok. btw:=20 Adding to [1] vp9 android code [6] offers me nice working vp9 hwdec = accell on rk3566/3588. =20 Great work! [1] = https://gitlab.collabora.com/detlev/linux/-/commits/add-vdpu381-and-383-to= -rkvdec-v7 [2] https://code.ffmpeg.org/Kwiboo/FFmpeg/src/branch/v4l2-request-n8.0.1 [3] https://github.com/MythTV/mythtv [4] https://github.com/warpme/minimyth2 [5] https://gitlab.collabora.com/detlev/ffmpeg [6] = https://github.com/dvab-sarma/android_kernel_rk_opi/commit/fd0b1b17cbdfcf0= c15bc9f411cc7127105157e57 =20 =20