From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F407459175; Wed, 13 Mar 2024 22:57:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710370659; cv=none; b=S2rjINgwizo6Y+CZsofDH9rTgOu6ABUSOw2mBGt9bm8t8lwwledjOk4cwiHxfm9Hpin7M67MxtMhcV6arwr+8sVTJAMLRoReBGQd3PckLe/T7mk7r+p2n8//jBIzqkDTw+Ys/cBuNJauXkasWt470p6qysKrvD/bYAmnNcxJsEU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710370659; c=relaxed/simple; bh=fhEKMDp9mGMZ7v7bPio8nfMLeshVTznOT/0NauTYUDY=; h=Message-ID:Content-Type:MIME-Version:In-Reply-To:References: Subject:From:Cc:To:Date; b=uUWXW4uvnBT1NXCDsCSefuZtmRwt1nlp5rooD3ti3a1E5dNYJrnFo1nawAkNwxnkz93R3RV6Jc2W5uRVSFekUzYq6H+p8E47Z6mWKeEvQZHElb1BabnDzaGWB8Urcocsg9B/sqTaH5eGJQAK2XHIqOaX02STmSSNIpWGyHsuZyw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=rOGnVL1H; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rOGnVL1H" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3B495C433F1; Wed, 13 Mar 2024 22:57:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710370658; bh=fhEKMDp9mGMZ7v7bPio8nfMLeshVTznOT/0NauTYUDY=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=rOGnVL1HARPz334CSqeD1U/hcmfeFVCUSzsyrQONOhk9uuTXwqpI0QujUyKrHfOeA LrGmEhGYoQvzPDaTnW1JDY0IVJD9cL22uq5Z2APjbpsZYb7+wgupyQQpj5bCc+vbSm oEPs52em7h/MuXTFCJ4gDrLYq+RC0fM/bnihJejqCdZdMSRZkODqh1D/uOfPxRJ+ix 1Rtk0kbqXQcgopZEm01GAND6dLF3C+xO3guehBXW9qLshmFuJwaxX6rjoa2WPoVTNX jIjwy40HpF/N4Fo7RGqpksYtQucksXgzaeEQyuKhf6WZh25PYFME5Dh11kjJr8/lBW +ODmL7RuAJYhg== Message-ID: <219f3eeba68fd0542d4954205c35bafa.sboyd@kernel.org> Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20240311-apss-ipq-pll-ipq5018-hang-v1-1-8ed42b7a904d@gmail.com> References: <20240311-apss-ipq-pll-ipq5018-hang-v1-1-8ed42b7a904d@gmail.com> Subject: Re: [PATCH] clk: qcom: apss-ipq-pll: use stromer ops for IPQ5018 to fix boot failure From: Stephen Boyd Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Gabor Juhos To: Bjorn Andersson , Dmitry Baryshkov , Gabor Juhos , Gokul Sriram Palanisamy , Konrad Dybcio , Michael Turquette , Sricharan Ramabadhran Date: Wed, 13 Mar 2024 15:57:36 -0700 User-Agent: alot/0.10 Quoting Gabor Juhos (2024-03-11 08:06:36) > diff --git a/drivers/clk/qcom/apss-ipq-pll.c b/drivers/clk/qcom/apss-ipq-= pll.c > index 678b805f13d45..11f1ae59438f7 100644 > --- a/drivers/clk/qcom/apss-ipq-pll.c > +++ b/drivers/clk/qcom/apss-ipq-pll.c > @@ -55,6 +55,24 @@ static struct clk_alpha_pll ipq_pll_huayra =3D { > }, > }; > =20 > +static struct clk_alpha_pll ipq_pll_stromer =3D { > + .offset =3D 0x0, > + .regs =3D ipq_pll_offsets[CLK_ALPHA_PLL_TYPE_STROMER_PLUS], > + .flags =3D SUPPORTS_DYNAMIC_UPDATE, > + .clkr =3D { > + .enable_reg =3D 0x0, > + .enable_mask =3D BIT(0), > + .hw.init =3D &(struct clk_init_data){ const?