public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Oliver Neukum <oneukum@suse.com>
To: syzbot <syzbot+ffba8e636870dac0e0c0@syzkaller.appspotmail.com>,
	linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
	linux-usb@vger.kernel.org, mchehab@kernel.org, sean@mess.org,
	syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [media?] WARNING in iguanair_probe/usb_submit_urb (2)
Date: Mon, 25 Nov 2024 15:27:28 +0100	[thread overview]
Message-ID: <21c2fc3f-e55a-47bb-a51b-b53e5cab1e67@suse.com> (raw)
In-Reply-To: <673f740d.050a0220.3c9d61.0176.GAE@google.com>

[-- Attachment #1: Type: text/plain, Size: 233 bytes --]



On 21.11.24 18:55, syzbot wrote:

> #syz test: git://repo/address.git branch-or-commit-hash
> If you attach or paste a git patch, syzbot will apply it before testing.
> 
#syz test:  https://github.com/google/kasan.git 43fb83c17ba2

[-- Attachment #2: iguana.patch --]
[-- Type: text/x-patch, Size: 495 bytes --]

diff --git a/drivers/media/rc/iguanair.c b/drivers/media/rc/iguanair.c
index 276bf3c8a8cb..8af94246e591 100644
--- a/drivers/media/rc/iguanair.c
+++ b/drivers/media/rc/iguanair.c
@@ -194,8 +194,10 @@ static int iguanair_send(struct iguanair *ir, unsigned size)
 	if (rc)
 		return rc;
 
-	if (wait_for_completion_timeout(&ir->completion, TIMEOUT) == 0)
+	if (wait_for_completion_timeout(&ir->completion, TIMEOUT) == 0) {
+		usb_kill_urb(ir->urb_out);
 		return -ETIMEDOUT;
+	}
 
 	return rc;
 }

  reply	other threads:[~2024-11-25 14:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-26 21:05 [syzbot] [media?] WARNING in iguanair_probe/usb_submit_urb (2) syzbot
2024-11-21 17:55 ` syzbot
2024-11-25 14:27   ` Oliver Neukum [this message]
2024-11-25 16:00     ` syzbot
2024-11-24  6:15 ` syzbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21c2fc3f-e55a-47bb-a51b-b53e5cab1e67@suse.com \
    --to=oneukum@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=sean@mess.org \
    --cc=syzbot+ffba8e636870dac0e0c0@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox