public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Ilya K <me@0upti.me>
Cc: Pratap Nirujogi <pratap.nirujogi@amd.com>,
	 Hans de Goede <hdegoede@redhat.com>,
	W_Armin@gmx.de,  mario.limonciello@amd.com,
	platform-driver-x86@vger.kernel.org,
	 LKML <linux-kernel@vger.kernel.org>,
	benjamin.chan@amd.com, bin.du@amd.com,
	 gjorgji.rosikopulos@amd.com, king.li@amd.com, dantony@amd.com
Subject: Re: [PATCH v12] platform/x86: Add AMD ISP platform config for OV05C10
Date: Tue, 6 May 2025 15:53:28 +0300 (EEST)	[thread overview]
Message-ID: <21c9d764-4945-4837-93dc-ab58f22f8668@linux.intel.com> (raw)
In-Reply-To: <9061d5a7-c1f6-47ad-b60a-226e48021d62@0upti.me>

On Tue, 6 May 2025, Ilya K wrote:

> > +#define AMDISP_OV05C10_I2C_ADDR		0x10
> > +#define AMDISP_OV05C10_PLAT_NAME	"amdisp_ov05c10_platform"
> > +#define AMDISP_OV05C10_HID		"OMNI5C10"
> > +#define AMDISP_OV05C10_REMOTE_EP_NAME	"ov05c10_isp_4_1_1"
> > +#define AMD_ISP_PLAT_DRV_NAME		"amd-isp4"
> 
> Hey folks, I know v12 might be a bit too late for this one, but I've got 
> another device here (Asus GZ302EA tablet) with a very similar camera 
> setup, but a different sensor (OV13B10), and it looks like this driver 
> just assumes a certain hardcoded configuration... I wonder if it makes 
> sense to reorganize the code so that more sensor configurations can be 
> added without making a separate module? I'd be happy to help with 
> refactoring/testing/etc, if people are interested.

v12 is not too late, and besides, v9..v12 has happened within 5 days 
which is rather short time (hint to the submitter that there's no need 
to burn patch series version numbers at that speed :-)).

I'll give folks some time to sort this out if you need to add e.g., some 
driver_data instead.

-- 
 i.


  reply	other threads:[~2025-05-06 12:53 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-05 17:11 [PATCH v12] platform/x86: Add AMD ISP platform config for OV05C10 Pratap Nirujogi
2025-05-06 12:13 ` Ilya K
2025-05-06 12:53   ` Ilpo Järvinen [this message]
2025-05-07 20:05     ` Nirujogi, Pratap
2025-05-08  8:52       ` Ilpo Järvinen
2025-05-08 23:00         ` Nirujogi, Pratap
2025-05-06 13:00 ` Ilpo Järvinen
2025-05-07 20:06   ` Nirujogi, Pratap
2025-05-06 15:37 ` Sakari Ailus
2025-05-07 20:16   ` Nirujogi, Pratap
2025-05-08  5:44     ` Sakari Ailus
2025-05-08 23:05       ` Nirujogi, Pratap
2025-05-07 21:13   ` Hans de Goede
2025-05-08  7:17     ` Sakari Ailus
2025-05-08 23:13       ` Nirujogi, Pratap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21c9d764-4945-4837-93dc-ab58f22f8668@linux.intel.com \
    --to=ilpo.jarvinen@linux.intel.com \
    --cc=W_Armin@gmx.de \
    --cc=benjamin.chan@amd.com \
    --cc=bin.du@amd.com \
    --cc=dantony@amd.com \
    --cc=gjorgji.rosikopulos@amd.com \
    --cc=hdegoede@redhat.com \
    --cc=king.li@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=me@0upti.me \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=pratap.nirujogi@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox